I thought this module would allow me to create fields as the D6 default profile.module and the content-profile.module did. I can find any of that functionality in this module. There is no docs that show this either. What is the purpose of this module if you can't create fields?

CommentFileSizeAuthor
#4 994570.profile2.enable-field-ui-notice.patch769 bytesjoachim

Comments

carlmcdade’s picture

carlmcdade commented
Title: Does do what is expected » Fields UI should set as a dependancy

If Fields UI is not set because of a minimal install there will be confusion. This also applies to the core content creation module which also requires Fields UI

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Fields UI should set as a dependancy » Fields UI should set as a dependancy?
Category: bug » task

I'm unsure about that - if people really want to disable the field_ui they should be able too. Also, as said core does it the same way. However, yes at least a note during installation of the module suggesting the user to also activate the field_ui module would make sense.

joachim’s picture

joachim commented

A dsm() in hook_enable should be fine.

joachim’s picture

joachim commented
Title: Fields UI should set as a dependancy? » Fields UI should set as a dependency?
Status: Active » Needs review
StatusFileSize
new 994570.profile2.enable-field-ui-notice.patch769 bytes

Here's a patch for review.

ericbroder’s picture

ericbroder commented

Patch works for me. When I enable Profile 2 module, but Field UI module is not enabled, I get a message that says:

You should enable Field UI module to create fields on profiles.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

But we shouldn't show the message if installed with an installation profile. see the other message in profile_install(). Although, I think we should drupal_installation_attempted() instead of checking for a batch.

fago’s picture

fago
Primary language German
Location Vienna
commented

>Although, I think we should drupal_installation_attempted() instead of checking for a batch.

I've done now so, as the batch check broke the tests with a recent d7. The function seems to work though.

caligari’s picture

caligari commented
Component: User interface » Code
Priority: Normal » Major
Status: Needs work » Needs review

I agree. field_ui is a direct dependency so "manage fields" and "manage display" operations at admin/structure/profiles do not work.

It must be added the line (profile2.info):

dependencies[] = field_ui