The second user_save() triggers the account activation email, which is not useful and sometimes confusing. Caused by #574194: User feature - import list of subsite accounts to master site

CommentFileSizeAuthor
#1 bakery.diff901 bytesdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new bakery.diff901 bytes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Now deployed on g.d.o for testing.

drumm’s picture

drumm
he/him
Location NY, US
commented

How's the testing going?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I had only heard one complaint about this in the ~weeks that it was buggy and since deploying it I've heard nothinng. Not sure that's valid.

drumm’s picture

drumm
he/him
Location NY, US
commented

For association and API, I turned off all account activation emails from user module, after getting ~2-3 complaints in a day. It is confusing because you are already logged in and do not need additional instructions.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I'm not sure about the idea of not needing additional instructions. That's true for some sites but not all. On g.d.o I changed the mail to include pointers to important pages for g.d.o. But yes, in general we shouldn't be sending this mail - I'll try to actually review soon unless someone else gets it first.

drumm’s picture

drumm
he/him
Location NY, US
commented

The current behavior of the notifications is an unintentional side-effect of #574194: User feature - import list of subsite accounts to master site.

Bakery should provide its own notifications UI for any possible notifications. They are different enough from the ones in core.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Reviewed & tested by the community

I was concerned about an account being blocked on the master and this not respecting it, but if the status is set to be synced, then it should be correctly handled.

I think this is RTBC.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Now fixed - http://drupal.org/cvs?commit=504608

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Patch (to be ported) » Fixed

This looks good on the 7.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.