Closed (fixed)
Project:
Advanced Forum
Version:
6.x-2.x-dev
Component:
Views
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Dec 2010 at 21:18 UTC
Updated:
31 Dec 2010 at 16:30 UTC
When combining multiple fields into the same column, the value in the "Separator" column doesn't ever display. The most obvious result is that the "(x new)" value in the "Replies" column does not display on a new line. It also makes it harder to add stuff to the view.
Comments
Comment #1
michelleHmm... Strange. The original title is too broad. Obviously it does work because the last poster & last reply time get a br as they should. And the new replies not being on a separate line isn't a bug because there's nothing in there to put it on a separate line. That's a good FR, though, as it does look better that way.
That said, when I went to implement this as a FR, I found that adding the br doesn't work there. I'm a bit mystified at the moment as to why it doesn't work and will need to dig into the code. Will keep this as a bug for now until I figure out what's wrong.
Michelle
Comment #2
meustrus commentedI believe that the reason it works with "last poster" and "last reply" is because the <br /> is being inserted by a "Rewrite the output of this field," NOT by the separator in the Forum Topic List view configuration.
Comment #3
michelleThat's a good guess and the first thing I thought of but, no, it's definitely using the br in the separator. The rewrite just adds the "by" in front.
My guess is there's something in the template file customizations that's causing a problem. Not sure I have enough brainpower tonight to figure it out, though. Been a long day.
Michelle
Comment #4
michelleThis is very, very bizarre. I went and changed all the separators to "SEP1" etc, including the one between the last poster and last post time that is currently working. I did a dsm to see what was getting to the preprocess and they are all empty except for the last post one which is still coming through as br even though I changed it. This makes no sense. I've tried clearing the cache and that isn't helping. If I export the view, it even shows the br still there. And to make this even weirder, the preview of the view on the edit view page is showing the changed separators!
This is one serious WTF LOL!
Will keep digging...
Michelle
Comment #5
michelleWell, I just spent the last hour digging, trying to figure this bizarre behavior out only to finally realize the problem is that I was changing the active topics view instead of the topic list view. Gah.
When changing the right view, this works just fine. LOL! So changing this to a feature request because putting the #new on the next line makes sense since the topic lines are 2 lines high anyway.
At this point, I don't trust myself to commit anything. I'm obviously not in good enough mental shape. LOL! It's a minor change but I'll make it tomorrow after I've gotten some sleep.
Times like this I'm glad no one is paying me for this... An hour wasted on something that wasn't even broken... Ugh.
Michelle
Comment #6
meustrus commentedWell, that's nice and all, but I'm pretty sure in my situation it's what I described. Given your testing, it's probably something wrong with my implementation. Any ideas? Something about template file customizations?
Comment #7
michelleNot really... Unless you haven't upgraded in a while and are hitting an already fixed bug. This is working just fine in the current code.
Michelle
Comment #8
meustrus commentedI haven't updated for the last couple of dev releases because I'm waiting for your go-ahead on the image-replace span's. Haven't heard that the code for that is stable yet.
Comment #9
michelleOk, moved this to a new line on all affected views. I also changed it from "(N new)" to "View N new" since I remember being new to Drupal and not realizing I could click that link to see the new posts. Maybe it's just me missing the obvious but I thought it might help. :)
Michelle