This patch fixes the basic upgrade issues; there are probably more bugs in the actual display, but this gets through the initial errors.
There's no need for the .install file any more, the dependencies field in .info covers that.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | timeline_dp5_2.patch | 4.97 KB | jmiccolis |
| #4 | timeline_dp5.patch | 5.48 KB | jmiccolis |
| timeline-5.patch | 1.92 KB | hickory |
Comments
Comment #1
Arto commentedComment #2
Arto commentedThanks for the patch, hickory!
I will look into branching for DRUPAL-5 and applying the patch once I've finished the 4.7.x-1.0 version of the module, which should be in the next few weeks.
Comment #3
Ian Ward commentedHi Hickory and Arto,
Is it worth re-rolling this patch for head now? Does anyone already have the timeline up on 5, or does a new patch need to be created? We (probably Jeff at Development Seed) may be able to do so, if anyone hasn't done so already.
Thanks,
Ian
Comment #4
jmiccolis commentedAttached is a patch that wil upgrade timeline for drupal 5.1. Also, as is noted above the .install file can be removed, and I'll attach a .info to a follow up.
Comment #5
jmiccolis commentedNevermind what I said about a .info file... it's already in cvs :)
Comment #6
Sanka-1 commentedHow do I intsall this patch?
Comment #7
jmiccolis commentedSanka, you'll need to use the "patch" program. There are instuctions over here -> http://drupal.org/node/60108
Comment #8
Arto commentedThanks for the patch, Jeff. I will branch DRUPAL-5 based on it as soon as I've committed some pending minor features and bug fixes.
Comment #9
mariagwyn commentedsubscribing; just want to know when dpl5 version is ready.
Comment #10
JohnG-1 commentedI like tracking, I like tracking, I like tracking, and I like to track ... (for anyone who remembers Not The Nine o'Clock News; if not don't worry about it ;)
Comment #11
jwilde commentedHey Guys,
I tried applying the above patch to head but I can't get timeline to work with 5.1. Can somebody post the updated module and .inc files for 5.1?
Thanks,
Jim
Comment #12
mariagwyn commentedI just want to second the posting of the updated code. I attempted to add timeline, and it caused a fatal error in the site. Decided to wait for the updated code.
Comment #13
jmiccolis commentedI've rolled a new patch. It should work a bit better with the newer version of the module, and fixes that errors some people were having with module_exist vs module_exists.
Comment #14
matt_paz commentedsubscribing
Comment #15
litwol commentedsubscribing
Comment #16
Arto commentedI'm about to tag version 1.1 of the module for Drupal 4.7, and this would be a good time to branch for 5.x, too.
The only problem is, I won't myself be needing to run this module on 5.x for some months yet, and I don't at present have all that much time to work on it in the first place. Branching 5.x means double the patching/testing. It'd be ideal if someone with a vested interest in running this on 5.x would be able to help out here so that the module doesn't stagnate.
Jeff, you're the logical candidate - would you be willing to serve as a maintainer for the 5.x branch? I would enable CVS access for you, and we would need to collaborate to keep the branches in sync (although I don't, at the moment, anticipate doing much more than just bug fixes on the 4.7 branch).
Comment #17
t4him commentedsubscribing. looking for D/5.1 solution. Thank You for the effort and great work guys'! i am documenting the history of a 1920's race car and this module will be fantastic for this project.
Comment #18
jmiccolis commented@Arto - Yes, I would be happy to maintain the 5.x Branch. Let me know how you would like to coordinate for a 5.x release.
Comment #19
floretan commentedThere is one project I'm working on where this module would be perfect, and in general it's just a pretty cool module.
I would like to help upgrade and maintain this module (I have experience with both php and Drupal), so that there can be a 5.x release soon. Just let me know what I should do.
Comment #20
Arto commentedI've been in touch with Jeff privately and we're proceeding on that front. I don't generally have time to work on open-source during the work week, hence the slow responses. But this weekend I'll branch for 5.x, and release 1.1 for 4.7 and 5.1, and let Jeff have a go at it :-)
Floarian, thanks for your offer. I'm open to adding more maintainers, but let's see how collaboration goes with two people, first. I'll definitely keep your offer in mind.
Comment #21
Arto commentedI've now branched the module for Drupal 5.x and applied Jeff's patch more or less verbatim in changeset [63453]. Jeff, you also have CVS access to the project now (further information in a private e-mail).
Before releasing the first version for 5.x, we need to address the only currently open critical issue, #79472. (For those who want to try the 5.x branch earlier, the timeline 5.x-1.x-dev tarball should rebuild within 12 hours. Please report bugs or, better yet, provide patches.)
Florian and others who want to contribute to this project, please help provide patches for known bugs, or implement any of the numerous open feature requests if they strike your fancy. Developers who submit high-quality patches to the project could certainly be given CVS access.
Comment #22
Arto commentedJeff confirmed the 5.x dev tarball works fine with his 5.x test setup, so go ahead and grab that if you want to use this on 5.1.
I'll roll a release 1.1 for both 4.7 and 5.x once a minor remaining bug has been fixed.
Comment #23
(not verified) commented