Is there any particular reason the 'Main menu' heading is added to the primary links display (in page.tpl.php)? I can't think of one theme I've ever created where I explicitly wanted to display a heading anywhere around the primary links, as they are pretty obviously the primary links/navigation... :-/

(And the same goes for secondary links...).

CommentFileSizeAuthor
#5 menu-update-995986-5.patch2.69 KBishmael-sanchez
#3 boron_995986.patch1.36 KBlevelos

Comments

geerlingguy’s picture

geerlingguy commented

If anything, I think this heading should have the .element-invisible class applied.

Scott J’s picture

Scott J commented

I think that headings are there to help sight-impaired readers find their way, as it may not be pretty obvious to them where the primary links are. But yes, they can be marked as invisible. Other themes such as Garland are doing it that way.

http://drupal.org/node/364219
http://drupal.org/update/theme/6/7#element-hidden
http://drupal.org/update/theme/6/7#theme-links-param
http://drupal.org/node/464472

levelos’s picture

levelos commented
Status: Active » Needs review
StatusFileSize
new boron_995986.patch1.36 KB

Here's a patch to fix the problem.

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

Please commit - this fixes some layout errors in the MM theme, too... #1057752: Fix various layout issues (from fresh Drupal install).

ishmael-sanchez’s picture

ishmael-sanchez commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new menu-update-995986-5.patch2.69 KB

I have attached an updated patch that hides the menu headers and is a bit easier to read and the patch also includes a fix to put the menu links inline.

danlinn’s picture

danlinn commented
Status: Needs review » Patch (to be ported)

Hello,

I agree that this link should be hidden by default. However, having inline links is a styling choice. I'll apply the first patch.

Thanks,
Dan

geerlingguy’s picture

geerlingguy commented

Woot! More progress... I was beginning to worry Boron dev was lying dormant, but I've been noticing a bunch of FB ads recently, and now a new 1.0 release! Will this patch be applied soon? I'd still like to clean out a little bit of the cruft from my mm contrib theme, and release a 1.0 of that as well...

danlinn’s picture

danlinn commented

If you mean soon like 3 weeks, sure!

Sorry, although this work is sponsored by our company, I can only work on it as time allows. That said, I'm going to get this patch out today.

Thanks,
Dan

danlinn’s picture

danlinn commented
Status: Patch (to be ported) » Closed (fixed)
ishmael-sanchez’s picture

ishmael-sanchez commented

Are you looking for other maintainers for this theme?