Issues with Fields created during 6 to 7 upgrade

Moving this to 7.x-dev because that is where bug fixing happens. Please test with the latest dev version if the error still occurs. Also, please a list of modules you have installed and tell us about your server (php version, mysql version, etc etc).

@int: Standard policy is always that bugs are tested in dev. You can comment that you were using RC2, but if you move the version to rc2, it won't show up in lists for the developers. Also, all bugs need to be reproduced against the latest code, which is why it was set to postponed.

We also will need more information as marcvangend stated.

int, if I did anything to upset you, I apologize, I'm only trying to help. Maybe you're right: maybe all this information is not relevant in your case. However a large part of bug fixing is simply ruling out possibilities, so that's why these questions are always asked when someone creates a bug report.

I can verify the bug happening (I can't remember a verification like this before): I added $this->drupalPost('admin/structure/types/manage/story/fields/body', array(), t('Save settings')); to the end of NodeBodyUpgradePathTestCase::testNodeBodyUpgrade and I get Cannot add index <em class="placeholder">body_format</em> to table <em class="placeholder">field_data_body</em>: index already exists.. Looking at the issue.

Moved a few lines around in _update_7000_field_create_field and it works.

+++ modules/simpletest/tests/upgrade/upgrade.node.test	2010-12-13 21:42:20 +0000
@@ -39,6 +39,7 @@ class NodeBodyUpgradePathTestCase extend
+    $this->drupalPost('admin/structure/types/manage/story/fields/body', array(), t('Save settings'));

Let's prepend a comment for this drupalPost() -- otherwise, I foresee that someone will remove it (lacking knowledge what and why that test is important).

Powered by Dreditor.

To finish the issue, comment, node, system (for upload / file module) and taxonomy needs further upgrades to fix up the botched fields. Also, the test needs a quick comment.

@chx: nice catch.

Added / adjusted comments.
Will give a try to the update funcs to fix the existing. I make no promises for tonight, though.

Oops @ patch rolling.

+++ modules/simpletest/tests/upgrade/upgrade.node.test
@@ -39,6 +39,10 @@ class NodeBodyUpgradePathTestCase extends UpgradePathTestCase {
+    // Check that fields created during the upgrade can edited and resaved in

For the next reroll: Missing word: "can BE edited". Leaving at needs review.

Powered by Dreditor.

int, I should have known from the above replies that you eager to help, this is great, but also that you are not too familiar with the process and so I should have written up my reasons for leaving it at needs review -- is this the correct solution? is there more to be done? I need expert eyes on the patch. The remaining work is small and if I set it to needs work then there will be a lot fewer eyeballs.

For example, does the patch solve the problem for you? So far , noone tested it with a real life database.

Added an upgrade function to fix existing broken fields.

*Not fully tested*, so please backup your database before applying and testing - or wait till tomorrow night that I can fully test.

One thing for sure, + $data['columns'] = $field['columns']; is not necessary 'cos of the unset($data['columns'] in field crud.

I'm encountering the same problem at admin/structure/types/manage/story/fields/body when trying to modify fields. D7 is throwing the error: DatabaseSchemaObjectExistsException: Cannot add index body_format to table field_data_body: index already exists. in DatabaseSchema_mysql->addIndex() (line 433 of /var/www/vhosts/#####.com/httpdocs/D7/includes/database/mysql/schema.inc).

I tested the above patch with no success.

FYI: Testing on a D7 update of a fresh D6 install (with just a few test content nodes in place).

I tested the patch #18 on an upgrade of a clean D6.19 install with a few test nodes and it fixes the problem.

Thanks for the feedback.

@chx #19: correct. I'll update the patch tonight. I'll also double check the upgrade func.
Thus, needs work for now.

Ah, update.php fixed the problem. Thank you for the tip.

Fixed chx's remark in #19, and tested the upgrade in various case (from a D6 db, from an existing D6->D7 upgraded db, from an existing D7 db). The upgrade function is correct.
Patch attached.

However, I noticed another bug : in dbs upgraded from D6, drupal_get_schema('field_data_body') does not contain the 'foreign keys' entry.
That's it for tonight. Still CNW :-(.

The issue with 'foreign keys' I mentioned in #27 is actually a different bug, I'll open a separate issue.

The patch for the critical fix at hand here can be reviewed and committed independantly.
--> back to 'patch needs review' for #27

Meanwhile, the fact that fields created during a d6 upgrade don't have their 'foreign keys' is not critical, and can be fixed later on. 'foreign keys' are only runtime meta data for drupal_get_schema(), and don't affect actual db schemas.

We are good to go then.

I could reproduce this bug, and can confirm that this patch fixed the problem.

I committed the patch to CVS HEAD.

The code comments could use some work but that was pretty minor, so decided to go ahead anyway.

Sorry, couldn't handle the minor typo in the hook_update_N()

- * Fix fields definitions created during the d6 to d7 upgarde path.
+ * Fix fields definitions created during the d6 to d7 upgrade path.

Sure.

Committed to HEAD. Thanks!

Resetting title for history's sake.

I've a fresh install of 7.2.
I then copy the module, theme and libraries folder from my dev site.
I apply a dump of my dev database.
Everything works fine but i get this error when trying to create a new content type.

DatabaseSchemaObjectExistsException : La table field_data_body existe déjà. dans DatabaseSchema->createTable() (ligne 629 dans D:\Profiles\gboullan\Bureau\sog71\includes\database\schema.inc).

Everytime i try and create a new content type the body field is missing by default and i get this error.

EDIT: I guess it's because i should've cleared the database before applying the dump, the body field table was left over from clean install but wasn't referenced anymore in whatever other table is referencing existing fields.
Just had to delete the empty table: field_data_body and field_data_body_revision and it worked fine.

Please stop hijacking closed threads.

Get the following error when upgrading from version 7.7 to 6.22.

Notice: unserialize() [function.unserialize]: Error at offset 44 of 48 bytes in variable_initialize() (line 727 of /var/www/vhosts/mesutersoy.com/httpdocs/includes/bootstrap.inc).

The following updates returned messages
node module
Update #7006

* Failed: DatabaseSchemaObjectExistsException: Table field_data_body already exists. in DatabaseSchema->createTable() (line 629 of /var/www/vhosts/mesutersoy.com/httpdocs/includes/database/schema.inc).

Getting the same error : from 6.28 to 7.24

Update #7006
Failed: DatabaseSchemaObjectExistsException: Table field_data_body already exists. in DatabaseSchema->createTable()

Same here am getting the same error while upgrading from drupal 6.29 to drupal 7.25
The following updates returned messages
node module
Update #7006

Failed: DatabaseSchemaObjectExistsException: Table field_data_body already exists. in DatabaseSchema->createTable() (line 657 of C:\xampp\htdocs\YYY\includes\database\schema.inc).

taxonomy module
Update #7005

Failed: DatabaseSchemaObjectExistsException: Table taxonomy_update_7005 already exists. in DatabaseSchema->createTable() (line 657 of C:\xampp\htdocs\YYY\includes\database\schema.inc).