setting for image position isn't working

Symptoms:

The image position setting under Administer > Settings > Content Types > node type doesn't appear to be working correctly. Images are always shown below the body even when this setting is changed to "Show above node body".

Cause:

It looks like function _node_images_embed_body may be retrieving the wrong variable. It's looking at variable_get('node_images_body_position', ''), but the settings form is using variable_get('node_images_allow_'. $type, ''). As a result, an empty string is retrieved and the default case is always being used.

Resolution:

The code appears to work correctly if line 479 is changed from:

$position = variable_get('node_images_body_position', '');>

to:

$position = variable_get('node_images_allow_' . $node->type, '');

Sorry for not including a proper patch file. I'm still learning how to use CVS.

JM