Symptoms:

Clicking on a thumbnail opens a new window that displays the full size image. In many cases, however, the image is not shown full size because the new window is a little too small. The browser usually shows a scaled-down image that's reduced to fit the space available. I've noticed this happening in IE 7.0 and Firefox 2.0.

Cause:

It looks like function theme_node_images_view is not adding enough to $width and $height to allow for browser margins. It seems IE is reserving space for scroll bars even though none are shown.

Resolution:

The code appears to work better if lines 457 and 458 are changed from:

$width = $info[0] + 10;
$height = $info[1];

to:

$width = $info[0] + 36;
$height = $info[1] + 36;

Results:

With this patch, the image is shown full size; but margins around the image appear to be uneven. This is because space is needed for non-existant scroll bars. (There might be a better patch that tells the browser not to reserve space for scroll bars, but I'm happy with just getting a full size image.)

(Sorry again for not including a proper patch file.)

JM

Comments

stefano73’s picture

Status: Needs review » Fixed

Fixed in HEAD and 4.7.

Anonymous’s picture

Status: Fixed » Closed (fixed)