Trying to get property of non-object in filefield_file_download() [#996338]

With Private Files enabled in OS X with PHP 5.3 and Content, Filefield, and Imagefield enabled in Pressflow Drupal 6....

After saving a node with a new image attached:
Notice: Trying to get property of non-object in filefield_file_download() (line ... of ... filefield.module)

In my debugger $file is showing up as a bool with a value of 0 at line 137 of HEAD. I guess that 0 means NULL? Because changing

// If the file is not found in the database, we're not responsible for it.
if (!isset($file)) {
  return;
}

// If the file is not found in the database, we're not responsible for it.
if (empty($file)) {
  return;
}

resolves the issue.

OK?

Comment	File	Size	Author
#1	filefield-996338.patch	549 bytes	Soren Jones

Comments

Status	File	Size
new	filefield-996338.patch	549 bytes

Comment #2

Soren Jones commented 12 December 2010 at 21:12

Status:

Active

» Needs review

Comment #3

quicksketch

he/him

commented 12 December 2010 at 22:06

Status:

Needs review

» Reviewed & tested by the community

Hm, interesting. I wonder if isset() has ever really worked here. Clearly empty() is going to be a more robust check here. You running into this problem is enough that I think this change should be made regardless of if it works in some situations.