Symptoms:

The images tab shows on nodes where users do not have update privileges. This behavior is different than the "Edit node images" link, which only shows when a user has node update access.

Cause:

It seems that code to display the images tab is only checking user_access('create node images'). It should also check node_access('update', $node).

Resolution:

It might be possible to use code similar to the access check in function node_images_link, but I don't know exactly where it should go to disable the image tab.

Here's the check that's done for the "Edit node images" link (line 173):

if (node_access('update', $node) && user_access('create node images')) {

I don't have a lot of experience yet with Drupal forms, so I don't know where the fix should go. I think it might belong somewhere in function node_images_menu.

JM

Comments

stefano73’s picture

Status: Active » Fixed

Fixed in HEAD and 4.7.

Anonymous’s picture

Status: Fixed » Closed (fixed)