_system_update_utf8 regression [#99644]

The function _system_update_utf8 was in updates.inc in 4.7 and its utility lead to it being used by contrib modules in their update functions. In 5 its been moved to system.install which breaks a lot of these update functions. A grep of the contrib directory turns up 92 instances so this is going to be pretty important to a lot of module maintainers.

This patch simply moves the function to install.inc. Its trivial so I'm marking it RTBC.

Comment	File	Size	Author
	system_update_utf8.patch.txt	4.06 KB	neclimdul

Comments

Comment #1

dries commented 25 November 2006 at 09:55

Odd. How comes this is only detected this late in the game? Makes one wonder.

Comment #2

neclimdul

He/Him

commented 25 November 2006 at 18:53

The reason this was missed was probably that it was used by modules to update code from 4.6 to 4.7. As such, the only time the fatal error will show up on these modules is updating modules from 4.6 to 5.

Comment #3

chx commented 26 November 2006 at 11:02

Do we support jumping versions? Now is the time to decide: either remove 4.6 -> 4.7 updates or commit this one.

Comment #4

neclimdul

He/Him

commented 26 November 2006 at 19:08

That could be a big factor *but* it's a function that could still be useful to modules that for what ever reason didn't support UTF8. This happens a lot with new contrib developers.

Also, if we aren't supporting the jump shouldn't we start clearing out the old updates?

Comment #5

neclimdul

He/Him

commented 26 November 2006 at 19:14

Status:

Reviewed & tested by the community

» Needs review

Based on the hesitance to commit this I'm going to mark this for review to open the discussion. I think its fairly important to move it but I'm open to discussing it.