[line 23]
drupal_set_header("HTTP/1.1 301 Moved Permanently");

CommentFileSizeAuthor
#8 globalredirect-4.7-dev.patch1.3 KBhass

Comments

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Active » Fixed

Nice find! Thanks - committed.

Anonymous’s picture

Anonymous (not verified) commented

Should this fix be added to HEAD as well?

Anonymous’s picture

Anonymous (not verified) commented

And looking at the code from HEAD I see ``header("HTTP/1.1 301 Moved Permanently")'' in three places. Should they all be changed to ``drupal_set_header("HTTP/1.1 301 Moved Permanently")''?

Earnie
http://for-my-kids.com
http://give-me-an-offer.com

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Version: 4.7.x-1.1 » 7.x-1.x-dev
Assigned: Unassigned » nicholasthompson
Status: Fixed » Active

ah dammit... Cheers - I'm still getting used to CVS. I'll sort this out asap (after reading up on how to clear-up my repository.. its got a bit messy).

Tobias Maier’s picture

Tobias Maier commented
Status: Active » Fixed

I think this got fixed

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
hass’s picture

hass commented
Status: Closed (fixed) » Active

Bug isn't fixed in HEAD and 4.7.x-1.1

hass’s picture

hass commented
Version: 7.x-1.x-dev » 4.7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new globalredirect-4.7-dev.patch1.3 KB

here is the patch for this recurring bug.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Needs review » Fixed

Ok - hopefully this will put this one to bed. I've just commited the changes to DRUPAL-4-7 and applied those changes into DRUPAL-4-7--1-2-1.

I'll sort out HEAD another day (HEAD should probably be a version of 5.x or something like that...)

hass’s picture

hass commented

HEAD is 6.x
DRUPAL-5 is for 5.x

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

In that case I'll add a new entry to my "To Do" list to get Global Redirect working for Drupal 6.x (DRUPAL-HEAD I assume?)

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Fixed » Closed (fixed)