Howdy,

Everything for this module looked like it was working, but when I try to import more than one page at a time I get the following error:

Fatal error: Call to undefined function: dsm() in /home/denve7/public_html/modules/Add_On_Modules/import_html/import_html.module on line 1225

This error doesn't occur when I'm importing just images, or when pages have been previously imported.

I'm excited about this module and really want it to work for my site. Can you help?

Thanks,
Jason

Comments

dman’s picture

dsm() is shorthand for drupal_set_message().
It's just logging info.
I was defining it in my own debug lib until the devel.module started doing the same thing.
It certainly shouldn't still be there in released code, probably just an oversight.
You're free to comment that line out (just logging) or replace it with 'drupal_set_message' to see what and why it was complaining.

Otherwise I'll see if I can fix it sometime this week.

jfro’s picture

Thanks for getting back to me! This change worked for me.

ehowland’s picture

This same function call also creates an error in the 4.7.x-1.x-dev package.

dman’s picture

Status: Active » Closed (fixed)

Current (last months) release does not use dsm() at all.
Problem should be gone.

Hetta’s picture

Version: master » 4.7.x-1.x-dev
Priority: Critical » Minor
Status: Closed (fixed) » Active

Still active on today's download of the 4.7 version; the fix still works.

Also, the line set_time_limit(0);, added somewhere at the top of the script, avoids the problem of php timeouts.

dman’s picture

The 'current' download of 4.7 was actually a bundle of the last stable release - Oct-Nov last year.
Most fixes were applied to the 4.7 'dev' version.

I've attempted to tag what should have been last weeks stable as Drupal-4-7--2-0
... I really don't know if the bundler will roll that correctly.

I do know that

cvs co -d import_html -r DRUPAL-4-7--2-0 contributions/modules/import_html

does successfully retrieve the correct 4.7 version.

Some CVS magic still needs to happen to get that bundling to work :(

Hetta’s picture

Alright, the full command to checkout the cvs version is:
cvs -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal co -d import_html -r DRUPAL-4-7--2-0 contributions/modules/import_html - if you're an anonymous user.

I'll give it a twirl - many thanks for such a useful module!

dman’s picture

I learnt yesterday that I missed the step where I have to manually make a Drupal.org release node to support the newly tagged CVS 'release'. I thought it was automatic.

It should now "roll like that" ... sometime in the next period
http://drupal.org/node/120493

dman’s picture

Status: Active » Closed (fixed)

long fixed