After saving a nodequeue, I get:

Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form_submit()

CommentFileSizeAuthor
#12 nodequeue-fix_undefined_property_new-997104-12.patch471 byteskolier
#11 nodequeue-Fix_undefined_new_property-997104-11.patch412 byteskolier
#10 nodequeue-Fix_undefined_new_property-997104-10.patch412 byteskolier
#7 nodequeue_undefined_property_997104_7.patch428 byteskurtzhong
#1 nodequeue_notice_997104.patch380 bytesbblake

Comments

bblake’s picture

bblake commented
StatusFileSize
new nodequeue_notice_997104.patch380 bytes

Patch included

bblake’s picture

bblake commented
Status: Active » Needs review
slashrsm’s picture

slashrsm commented

Works fine for me.

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community
merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kurtzhong’s picture

kurtzhong commented
StatusFileSize
new nodequeue_undefined_property_997104_7.patch428 bytes

Sorry for opening this old issue, but it's the almost the same issue:

  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 504 of nodequeue/includes/nodequeue.admin.inc).
  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 551 of nodequeue/includes/nodequeue.admin.inc).
  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 555 of nodequeue/includes/nodequeue.admin.inc).

The following is the patch:

kurtzhong’s picture

kurtzhong commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Closed (fixed) » Active

Oh, i forgot to change the issue status.

darrenmothersele’s picture

darrenmothersele commented

yep, I was getting this too (on 7.x-3.x-dev). Patch in #7 fixes it.

kolier’s picture

kolier commented
StatusFileSize
new nodequeue-Fix_undefined_new_property-997104-10.patch412 bytes

I think it's better to add the new property in function nodequeue_load_queues().

kolier’s picture

kolier commented
Status: Active » Needs review
StatusFileSize
new nodequeue-Fix_undefined_new_property-997104-11.patch412 bytes

Reupload for the test bot to test the patch.

kolier’s picture

kolier commented
StatusFileSize
new nodequeue-fix_undefined_property_new-997104-12.patch471 bytes

A fixed one.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed

Committed, thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.