I have created a taglist thats works as I need it to. However, if I check the 'HTML attributes (attributes)' checkbox and add the content class='embedded-content' into the textfield provided, the wysiwyg integration breaks. Clicking the button brings up the p[popup window as normal, but clicking on the names of one of my views to insert the embedded view, doesn't work. Instead, there is a javascript error:

Uncaught SyntaxError: Unexpected identifier

CommentFileSizeAuthor
#3 997800-linodef-html-encode-attributes.patch931 bytesmrfelton
#2 997800-linodef-html-encode-attributes.patch805 bytesmrfelton

Comments

mrfelton’s picture

mrfelton commented

Changing class='embedded-content' to class="embedded-content"(using double quotes instead) gets it working again, but then you end up with a broken tag. e.g.

[#related_content,type="view",nolink,attributes="class="embedded-content"",visibility="full",display="block_1"]

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 997800-linodef-html-encode-attributes.patch805 bytes

The attached patch resolves by html encoding the attributes.

mrfelton’s picture

mrfelton commented
StatusFileSize
new 997800-linodef-html-encode-attributes.patch931 bytes

Attached patch works slightly better, only encoding the string version. This ensures that when the array is themes as an item list (in the popup help text) there is no double encoding.