When enabling 'Bandwidth Optimisation' for 'Aggregate and compress CSS files' it fails to style the editor.
'Aggregate JavaScript files' works fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | elfinder-lib-1.2-dev.tar_.gz | 832.68 KB | ph0enix |
| #13 | elfinder-7.x-1.x-dev-20110510.tar_.gz | 21.63 KB | ph0enix |
Comments
Comment #1
bachomp commentedsolution: set the type to external rather than module. This will ensure that the css files are not included in the aggregation
change from (line 127 ... elfinder.module)
drupal_add_css($libpath . '/js/ui-themes/base/ui.all.css', 'module', 'screen');
drupal_add_css($libpath . '/css/elfinder.css', 'module', 'screen');
drupal_add_css($path . '/css/elfinder.css', 'module', 'screen');
if (VERSION == 7) {
drupal_add_css($path . '/css/elfinder.d7.css', 'module', 'screen');
}
to
$options = array('type' => 'external', 'media' => 'screen');
drupal_add_css($libpath . '/js/ui-themes/base/ui.all.css', $options);
drupal_add_css($libpath . '/css/elfinder.css', $options);
drupal_add_css($path . '/css/elfinder.css', $options);
if (VERSION == 7) {
drupal_add_css($path . '/css/elfinder.d7.css', $options);
}
Comment #2
ph0enix commentedThank You for patch. Implemented in dev version and in 0.6 release.
Comment #3
gargsuchi commentedIn case you are using D6 and facing the same issue, please change the same lines as follows:
Hope this helps somebody.
Thanks
Suchi
Comment #4
ph0enix commentedThank You! Added to dev branch.
Comment #5
ph0enix commentedFix available in Mar 13 dev version.
Comment #7
bbbo commentedwith the latest dev on D7 I still had to change
line 110 of elfinder.module from
$options = array('type' => 'module', 'media' => 'screen');to
$options = array('type' => 'external', 'media' => 'screen');to get things working with CSS aggregation.
Comment #8
Jean Gionet commentedI can confirm this as well! #7 fixed it for me! thxs
Comment #9
merro commented#7 - same here - latest dev
Comment #10
ph0enix commentedAs I know if change type to external, it will cause this issue #1087220: Latest DEV version breaks elFinder. I need to find way how to fix both issues.
Comment #11
goldHave just tested this #7 on 7.x-1.x-dev as of this date and it worked fine for me. If we could get this checked in and perhaps a 0.7 release? This is about to be deployed on a production server.
If there's any other patches that need testing to get to 1.0 I'd be happy to test them out (now that I have a -dev version running)
Update: Works in standards compliant browsers. Not in lte IE8. :/
Comment #12
goldremoving the +1 tag. (thought they were related to the comments, not the issue.)
Comment #13
ph0enix commentedPer http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_ad... 'module' is no longer used as type (I still can't reproduce this issue). So #7 fix is correct in this case. But we still have #1087220: Latest DEV version breaks elFinder. I think I have found solution for both issues, please test it (backup existing site/database first - this version have some core functions rewritten).
It will be great if you can help with testing of following:
1. Test image insertion in few wysiwyg editor profiles - wysiwyg integration procedures was rewritten
2. Test attached upcoming elFinder 1.2 library (backup previous library, unpack attached elfinder-lib-1.2-dev.tar_.gz to sites/all/libraries)
3. Test Use system jQuery option (admin/config/media/elfinder)
Comment #14
ph0enix commented