When creating a banner, one can enter a URL to forward to the vendor. Currently only 128 characters can be entered, although some vendor links are longer. In the database "banner" the URL can be 255 characters long. Could one change the maxlength property of the URL field?
I understand that I could construct a longer URL within the the text field (for a text banner). But this is not as clean, and I assume that clicks on that link (in the text-field) won't get counted, since only those to ./banner/108.. which forward to the URL (from the URL field) get counted.

CommentFileSizeAuthor
#2 banner.module.url-maxlength.patch706 bytessun

Comments

rseiser’s picture

If one enters a longer URL into the database directly it actually works. Even when afterwards editing the banner in Drupal, a longer URL field is displayed, and it is not cut of when submitting the form. (One can still only enter less characters, but not more than the present URL length).

So it would still be great if one could enter up to 255 characters into the URL field. Then one wouldn't have to go through the database.

sun’s picture

Version: 4.7.x-1.x-dev » master
Category: feature » bug
StatusFileSize
new706 bytes

Attached patch fixes this issue for HEAD. Backport needed for 4.7 after commit.

sun’s picture

Status: Active » Needs review
wulff’s picture

Will be fixed in next commit. Thanks sun.

wulff’s picture

Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)