"if aggressive caching is enabled and the minimum cache time is non-zero..."

aggressive caching was removed in D7 :-p

CommentFileSizeAuthor
#2 999538-2.patch1.1 KBJosh The Geek
#1 999538-1.patch968 bytesJosh The Geek

Comments

Josh The Geek’s picture

Assigned: Unassigned » Josh The Geek
Status: Active » Needs review
StatusFileSize
new968 bytes

Patch.

Josh The Geek’s picture

StatusFileSize
new1.1 KB

Ugh. Forgot to add a period.

ovlaere’s picture

Ok, so here's my try at first review of a patch:

- checked the API for aggressive caching, and aggressive caching is indeed removed (as far as i could tell from the api?)
- documentation patch works as intended without sideeffects

so i guess my first review is a pass for you Josh.

Even though minor issue, i will leave this on needs review just to make sure some double checks me ;-)

Thx @ xjm on #drupal-contribute for helping me getting started!

Cheers,
Kiewie

xjm’s picture

Looks appropriate to me.

ovlaere’s picture

Status: Needs review » Reviewed & tested by the community

Changing status after discussion with xjm

tstoeckler’s picture

It's probably best to remove this documentation still, but if only for reference and historical accuracy:
This feature was not removed.
See the following code in _drupal_bootstrap_page_cache:

  // Check for a cache mode force from settings.php.
  if (variable_get('page_cache_without_database')) {
    $cache_enabled = TRUE;
  }

It's simply not documented anymore in default.settings.php.

dawehner’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D7
dries’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Moving to 7.x. Thanks for your first patch, Josh The Geek.

dries’s picture

Status: Fixed » Reviewed & tested by the community
Josh The Geek’s picture

Status: Reviewed & tested by the community » Fixed

Awesome!

Tor Arne Thune’s picture

Status: Fixed » Reviewed & tested by the community
Josh The Geek’s picture

Thank you, 1V. I didn't mean to change that.

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs backport to D7

Committed to 7.x as well. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.