Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
15 Dec 2010 at 23:17 UTC
Updated:
24 Apr 2011 at 23:21 UTC
Jump to comment: Most recent file
"if aggressive caching is enabled and the minimum cache time is non-zero..."
aggressive caching was removed in D7 :-p
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 999538-2.patch | 1.1 KB | Josh The Geek |
| #1 | 999538-1.patch | 968 bytes | Josh The Geek |
Comments
Comment #1
Josh The Geek commentedPatch.
Comment #2
Josh The Geek commentedUgh. Forgot to add a period.
Comment #3
ovlaere commentedOk, so here's my try at first review of a patch:
- checked the API for aggressive caching, and aggressive caching is indeed removed (as far as i could tell from the api?)
- documentation patch works as intended without sideeffects
so i guess my first review is a pass for you Josh.
Even though minor issue, i will leave this on needs review just to make sure some double checks me ;-)
Thx @ xjm on #drupal-contribute for helping me getting started!
Cheers,
Kiewie
Comment #4
xjmLooks appropriate to me.
Comment #5
ovlaere commentedChanging status after discussion with xjm
Comment #6
tstoecklerIt's probably best to remove this documentation still, but if only for reference and historical accuracy:
This feature was not removed.
See the following code in _drupal_bootstrap_page_cache:
It's simply not documented anymore in default.settings.php.
Comment #7
dawehnerComment #8
dries commentedCommitted to 8.x. Moving to 7.x. Thanks for your first patch, Josh The Geek.
Comment #9
dries commentedComment #10
Josh The Geek commentedAwesome!
Comment #11
Tor Arne Thune commentedComment #12
Josh The Geek commentedThank you, 1V. I didn't mean to change that.
Comment #13
webchickCommitted to 7.x as well. Thanks!