After loosing my selection the second time because i clicked on the wrong place :) I changed the Settings interface to use checkboxes. This could be a bit space wasting if there are hundreds of groups, but then also the select box is probably not very user friendly. They could also be wrapped in a collapsible fieldset.
Additionally, in my patch the url to the signup page is shown behind the enabled groups to avoid checking CiviCRM for the ids.
I don't know if people are interested in these changes, but I thought I'll share them...
Please note that the patches from #999822: Compatibility with CiviCRM 3.3 and #999834: Empty form submission problem where applied before creating this patch file.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | settings_checkboxes.patch | 3.68 KB | thomas.feichter |
| admin-settings-civicrm_subscribe.jpg | 17.15 KB | thomas.feichter | |
| settings_checkboxes.patch | 2.34 KB | thomas.feichter |
Comments
Comment #1
EvanDonovan commentedCan you re-roll the patch with the other patches separated out? Thanks, that will make it easier to review.
Comment #2
thomas.feichter commentedI attached a new patch without the other patches.
Please beware that I didn't check the impact of the changes on the subscription blocks in detail as I was not using them so far.
Comment #3
colemanw commented@thomasf
This functionality is already part of the webform civicrm integration module. :)
Comment #4
EvanDonovan commented@thomasf:
I wonder if actually the Better Select module might be a better solution for this, since multi-select does have the advantage of handling a lot of options well. I'll see whether that module can do the trick, and if so, I will mark this "won't fix" in favor of that as a solution.
@colemanw:
thomasf is referring to the settings form for the module, not the user-facing form? Is that what you're talking about as well.
Comment #5
colemanw commentedIn webform_civicrm, the "backend" settings render as checkboxes. The user facing form can be rendered either way, but defaults to checkboxes.
Comment #6
EvanDonovan commentedI would commit this if you can confirm that it works with the subscription blocks. Alternatively, if you want maintainership of the module, I could give that over to you, since I no longer use CiviCRM.
Comment #7
thomas.feichter commentedSorry for my late reply.
Subscription blocks seem to work fine on 3 live sites.
I'm not sure if I can find enough spare time to maintain the module properly.
What do you think about co-maintainership?
Comment #8
EvanDonovan commented@thomas.feichter: Sorry I didn't replied till now. That's not a problem with me. I've messaged you with more details.