marco

October 1, 2003

• Commit #8959 by marco at 05:23
  /sandbox/marco/fileapi/fs.module 1.15

  - setting descriptions are somewhat better now

September 29, 2003

• Commit #8967 by marco at 08:25
  /sandbox/marco/fileapi/fsadmin.module 1.1

  - added a "link" download method; this is much lighter and takes less disk space, but may not work on every platform so it's an option- moved administration interface to a new fsadmin.module
  - moved (and renamed) image_scale() to pgallery module
  - some cleanup (comments and other code style bits)
  This update tries to address one of the main criticisms about this module: "it does too much". So I moved all the unnecessary parts to other modules, although I couldn't make the rest just an include file because I need some hooks (settings, page, init, exit and others).
  About the other issue, "it is too high level/it highjacks upload data", I think it's not really a problem because:
  1) I still have to find something which you can't do with the init()/highjack part
  2) you can still use $_FILES if you want, ignoring the "highjacking", as the API doesn't delete anything; make everything you want with it and finally still take advantage of the API using fs_register() to save your data.
  I hope to elaborate more on this issues later today or tomorrow.

• Commit #8936 by marco at 08:23
  /sandbox/marco/fileapi/fileapi.README 1.14
  /sandbox/marco/fileapi/fs.module 1.14
  /sandbox/marco/fileapi/pgallery.module 1.10

  - added a "link" download method; this is much lighter and takes less disk space, but may not work on every platform so it's an option- moved administration interface to a new fsadmin.module
  - moved (and renamed) image_scale() to pgallery module
  - some cleanup (comments and other code style bits)
  
  This update tries to address one of the main criticisms about this module: "it does too much". So I moved all the unnecessary parts to other modules, although I couldn't make the rest just an include file because I need some hooks (settings, page, init, exit and others).
  About the other issue, "it is too high level/it highjacks upload data", I think it's not really a problem because:
  1) I still have to find something which you can't do with the init()/highjack part
  2) you can still use $_FILES if you want, ignoring the "highjacking", as the API doesn't delete anything; make everything you want with it and finally still take advantage of the API using fs_register() to save your data.
  
  I hope to elaborate more on this issues later today or tomorrow.

September 8, 2003

• Commit #8937 by marco at 07:52
  /sandbox/marco/fileapi/fileapi.README 1.13
  /sandbox/marco/fileapi/filestore.README 1.3
  /sandbox/marco/fileapi/fs.module 1.13

  - fixed a small chicken-egg bug

September 2, 2003

• Commit #8960 by marco at 11:27
  /sandbox/marco/fileapi/fs.module 1.12

  - bugfix: search in admin didn't work

• Commit #8938 by marco at 11:19
  /sandbox/marco/fileapi/fileapi.README 1.12
  /sandbox/marco/fileapi/filestore.module 1.1
  /sandbox/marco/fileapi/filestore.module.patch 1.3
  /sandbox/marco/fileapi/fs.module 1.11

  - in fs_url(), another small change to one-time urls (now finishing with the filename)- fixed the $param in filestore_form() and added the whole module to make testing easier (you still have to read filestore.README)

• Commit #8962 by marco at 05:41
  /sandbox/marco/fileapi/fs.module 1.9

  - made the one-time urls a bit more beautiful

• Commit #8963 by marco at 05:30
  /sandbox/marco/fileapi/fs.module 1.8

  - fixed a bug in _init() (thanks Moshe)

September 1, 2003

• Commit #8939 by marco at 17:16
  /sandbox/marco/fileapi/fileapi.README 1.11
  /sandbox/marco/fileapi/fs.module 1.7
  /sandbox/marco/fileapi/fs.mysql 1.4
  /sandbox/marco/fileapi/pgallery.module 1.8

  - security: added xss checks for data and filename- bugfix: removed call-time pass-by-reference
  - usability: renamed fs -> document repository in admin
  - internal change: now the hidden field is handled through the db instead of session
  - pgallery: explicitly uses enctype="multipart/form-data" so you don't need to patch common.inc anymore (I still think that patch would be handy, though)

August 29, 2003

• Commit #8940 by marco at 20:12
  /sandbox/marco/fileapi/fileapi.README 1.10
  /sandbox/marco/fileapi/filestore.module.patch 1.2
  /sandbox/marco/fileapi/filestore.README 1.2
  /sandbox/marco/fileapi/fs.module 1.6
  /sandbox/marco/fileapi/fs.mysql 1.3
  /sandbox/marco/fileapi/pgallery.module 1.7

  - added inline phpDoc to every public function- replaced filename with fid, but it's still a string; added a filename property that stores the original filename; these changes allow for files to keep their original name (this fixes "Bob's issue", see Kjartan's suggestions in the ml)
  - replaced readfile() with fopen()/fread()/fclose(), to lower memory usage
  - added ob_end_clean() before dumping the file to avoid caching
  - file data in database storage is store base64 encoded
  - some cleanup