Clean up after uninstall

Are these bugs specific to File Browser or are all modules that provide this kind of config subject to this error? I'm wondering if this should be a core issue or closed in lieu of an existing core issue.

The image style config should have a dependency on the module (somewhere).

OR you can move the config to a folder names "optional".
Than it will be installed if it doesn't exist yet.

@aspilicious Ah, that makes sense. I would prefer the dependency as both of those pieces of config are (mostly) useless without File Browser. Thanks for the tip!

Here's a patch that adds those missing dependencies.

I've had a similar problem with custom modules (and I just had this problem with File Browser too). The dependency may or may not be enough to get the config to remove itself properly. I've also taken to using hook_uninstall to clean up any configuration my module uses during the uninstall (suggestion came from elsewhere a few weeks ago, can't remember exactly where I read it first). For example, something like this:

function file_browser_uninstall() {
  Drupal::configFactory()->getEditable('image.style.file_entity_browser_thumbnail')->delete();
}

With a similar line for each part of the configuration that needs to be uninstalled. That might help to mitigate these types of issues.

This is a correct fix.

+++ b/file_browser.info.yml
@@ -10,6 +10,7 @@ dependencies:
+  - image

We can keep this as well.

I think it is ready now.

Ran drush si standard -y && drush en file_browser -y && drush pmu file_browser -y && drush en file_browser -y, no errors! Thanks @jibran.

Thanks @samuel.mortenson.

Created #2712669: Clean up after uninstall for content browser.

I believe this is actually the correct fix. The uninstall process will warn you config will be deleted this way.