Doesn't matter in which phase hook_requirements is, it is expected to return an array every time. If it returns NULL, it will break under certain conditions.

CommentFileSizeAuthor
#2 2717375-hook_requirements-have-to-return-an-array.patch1.21 KBchr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
2717375-hook_requirements-have-to-return-an-array.patch1.21 KB
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented

In what kind of situations will this break? It seems that ModuleHandlerInterface::invokeAll() is able to handle it.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented

array_merge in drupal_check_profile cant handle it. We try to enable media_entity in an install profile and there it breaks.

  • slashrsm committed 9ce472e on 8.x-1.x authored by chr.fritsch 
    Issue #2717375 by chr.fritsch, slashrsm: hook_requirements expected to...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs review » Fixed

Right. I wasn't able to find this usage, when I was searching codebase. Committed.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.