Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The paged LDAP query doesn't work - there are comments for it in the code too.
To reproduce:
- at server settings: enable 'Use LDAP Pagination' and set 'Pagination size limit' (e.g. 1000)
There will be no result for LDAP queries with php notices:
Undefined property: Drupal\ldap_servers\Entity\Server::$searchPageSize in Drupal\ldap_servers\Entity\Server->pagedLdapQuery()
Undefined property: Drupal\ldap_servers\Entity\Server::$searchPageStart in Drupal\ldap_servers\Entity\Server->pagedLdapQuery()
Undefined property: Drupal\ldap_servers\Entity\Server::$searchPageEnd in Drupal\ldap_servers\Entity\Server->pagedLdapQuery()
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | ldap_server_pagination-2832461-4.patch | 1.56 KB | szato |
| #4 | interdiff-2832461-2-4.txt | 373 bytes | szato |
Comments
Comment #2
szato CreditAttribution: szato at Brainsum for Tieto commentedComment #3
grahlHi szato
Thanks for your patch, just two questions:
One, why did add the constructor which just calls the parent constructor? AFAIK that is called either way, as long as you do not define __construct, doesn't it?
Two, do paged queries work for you with the attached patch or is this an initial patch to fix the obvious errors? I do not have a test setup to simulate paged queries.
Comment #4
szato CreditAttribution: szato at Brainsum for Tieto commented1) __construct doesn't make sense (it was left in from another attempt). I removed it - new patch attached.
2) yes, we are using this patch
Comment #6
grahlLooks good, thanks!