Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josephcheek created an issue. See original summary.

josephcheek’s picture

Status: Active » Needs review
FileSize
519 bytes

hey i created a patch for this! with @cosmicdreams' help!

josephcheek’s picture

Title: Add Change record to @deprecated for drupal_unlink in file.inc » Add Change record to @deprecated for all deprecated functions in file.inc
Issue summary: View changes
FileSize
4.06 KB

I decided to roll a single patch for all deprecated functions in this CR (@see https://www.drupal.org/node/2418133)

John Cook’s picture

Status: Needs review » Reviewed & tested by the community

There are only @see comment tags referring to the change log added in this patch.

After searching through the code, I couldn't find any missed deprecated functions that required the comment to be updated.

Because of this, I'm marking as RTBC.

cilefen’s picture

Status: Reviewed & tested by the community » Needs work

Thank you all.

file_directory_os_temp() and file_htaccess_lines() fall into the scope of the issue title but did not get @sees. file_directory_os_temp() has a change record. I am going to ask on the parent issue about what we are to do about deprecated constants. Also, there are constants that did not get @sees.

gaurav.kapoor’s picture

Status: Needs work » Needs review
FileSize
5.31 KB
1.25 KB
John Cook’s picture

Status: Needs review » Reviewed & tested by the community

@sees have been added to file_directory_os_temp(), file_htaccess_lines(), and the deprecated constants from cilefen's comment.

Again, I can't see anything else, but I missed some last time.

I'm setting to RTBC (until cilefen finds something else ;) ).

  • Gábor Hojtsy committed ba6f322 on 8.3.x
    Issue #2873775 by josephcheek, gaurav.kapoor, John Cook, cilefen: Add...

  • Gábor Hojtsy committed 3c7a778 on 8.4.x
    Issue #2873775 by josephcheek, gaurav.kapoor, John Cook, cilefen: Add...
Gábor Hojtsy’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

I verified that all functions and constants mentioned in the change notice got a @see (this is the reverse of what John Cook verified, so its validated both ways now). Thanks all!

xjm’s picture

xjm’s picture

Issue summary: View changes

(Just removing the issue relationship and instead mentioning this issue in the summary.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.