In trying to resolve some issues with users not getting redirected to on logout I'm testing the 2.x-dev branch. Now, instead of getting sent to /saml/sls on logout I'm seeing a 500 error:

Error: Call to a member function processSLO() on null in Drupal\samlauth\SamlService->sls() (line 291 of .../docroot/modules/contrib/samlauth/src/SamlService.php)

that line is:

$url = $this->samlAuth->processSLO(FALSE, NULL, FALSE, NULL, TRUE);

changing that line to $url = ''; resolves the issue and users are able to logout successfully and return to the homepage.

I'm not totally sure what's going on here so I'm not sure of the correct path to go forward, but I'm assuming just removing this line isn't it. :)

CommentFileSizeAuthor
#3 error_call_to_a_member_function_on_null-2910257-3.patch665 bytesnathandentzau
#2 error_call_to_a_member-2910257-2.patch723 bytesfroboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

froboy created an issue. See original summary.

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy at Palantir.net for American Medical Association commented
Status: Active » Needs review
FileSize
error_call_to_a_member-2910257-2.patch723 bytes

Patch seems to resolve the issue, but not sure if it breaks the error-checking going on here.

nathandentzau’s picture

nathandentzau
Location Rhode Island
CreditAttribution: nathandentzau at Oomph, Inc. commented
FileSize
error_call_to_a_member_function_on_null-2910257-3.patch665 bytes

Hi froboy,

There is a `getSamlAuth()` method that instantiates the OneLogin_Saml2_Auth object if the`samlAuth` property is null. I've attached a patch. Please test this. Thanks!

nathandentzau’s picture

nathandentzau
Location Rhode Island
CreditAttribution: nathandentzau at Oomph, Inc. commented
Assigned: Unassigned » nathandentzau

  • roderik committed 188d6d1 on 8.x-2.x authored by nathandentzau 
    Issue #2910257 by froboy, nathandentzau: Fix Error: Call to a member...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
CreditAttribution: roderik as a volunteer commented
Status: Needs review » Fixed

Thanks. This was an effect of an untested mistake in #2863975-5: Fix SLS.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.