Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

agentrickard’s picture

Status: Active » Needs review
FileSize
485 bytes

That was a nice bug report. Thanks for the context.

Here's a patch for testing.

mikelutz’s picture

Actually, it needs to go in the annotation for the source plugin, not the migration itself. I meant to file the patch earlier, I just didn't have time yesterday.

agentrickard’s picture

Ah. I didn't write that part and forgot it was there. Thanks.

agentrickard’s picture

As I understand https://www.drupal.org/node/2831566, we also should add destination_module to the template, which is provided as a convenience for developers.

Updated patch.

mikelutz’s picture

Ah yes, that is a good practice as well. My main concern with this issue was that once 8.5 drops today, If the source_module annotation isn't there, all Drupal migrations will error out if the module is installed, but yes, that is best practice, and if you want to finish a cleanup of the migrations, change the name of the 'migration_templates' directory to 'migrations' as well, since 'migration_templates' is deprecated too.

Either way, I've been recommending maintainers get this committed quickly so as to not break migrations with 8.5.

agentrickard’s picture

Status: Needs review » Fixed

Ok, fixed.

agentrickard’s picture

Well, I tagged alpha13, but can;t make a release yet.

mwebaze’s picture

It doesn't look like this issue has been fixed in 8.5. I am trying to upgrade from D7 to D8 and getting 'The name plugin must define the source_module property.'

agentrickard’s picture

@mwebaze that sounds like a core issue. alpha13 contains the code required by the change notice.

mwebaze’s picture

@agentrickard I figured out what was causing it. One of the contrib modules did implement its @MigrateSource with a source and destination id. The error is not so specific so I had to go through the contrib modules to find out which one has a migration plugin implemented and check for missing source_module id. Once I uninstalled it, it went fine

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.