Comply with Drupal coding standard

Add the patch for suppress warning.
The patch file 3014131_except_php_files.patch resolve the notices about the files except PHP files.

To avoid "Case breaking statements must be followed by a single blank line" errors.

Remove unused "use statement"

Remove unused variables.

@shidat

Thank you for the patches.

1. The patches in between comment #4 and #5 are identical? (3014131_warning_unused_use_statement.patch)
2. I'm concerned 3014131_except_php_files.patchto delete JS file(s) such as cloud.auto_refresh_list_all_instances.js as future reference.
3. I'm not confident whether the following change is really valid or not in the patch 3014131_warning_unused_variable.patch.
   
   Original:

   foreach (array_column($results['AvailabilityZones'], 'ZoneName') as $key => $availability_zone) {
     $zones[$availability_zone] = $availability_zone;
   }
   

   Patch:

   foreach (array_column($results['AvailabilityZones'], 'ZoneName') as $availability_zone) {
     $zones[$availability_zone] = $availability_zone;
   }
   

   It would be appreciated if you can write the test code for it.

@baldwinlouie

Could you please confirm about the patches?

1. The patches in between comment #4 and #5 are identical?

oops, It is my mistake. duplicate.
guan-san upload correct patch file.

2. I'm concerned 3014131_except_php_files.patchto delete JS file(s) ...

OK, I'll resume the JS.

3. I'm not confident whether the following change is really valid or not ...

In this code, there is no appearance $key in loop block. So, no need to store the loop index at $key variable, I think.

There should be no white space after an opening “{”

Comments may not appear after statements

Inline comments must end in full-stops, exclamation | | marks, colons, question marks, or closing parentheses

@shidat

Thank you for more patches.

My comments are here (I put the patch name in each item.)

1. 3014131_warning_unused_use_statement.patch: The patches in between comment #4 and #5 are identical?

   → OK, it looks good to me.

2. 3014131_except_php_files.patch: I'm concerned to delete JS file(s) such as cloud.auto_refresh_list_all_instances.js as future reference.

   → I mean that we should leave the one(s) as it is? (I want to get @baldwinlouie's feedback

3. 3014131_warning_unused_variable.patch: I'm not confident whether the following change is really valid or not in the patch.

   → I understand that waning by the tool, however I meant that I wanted you to make sure if it makes the same result in the following code since it is different in PHP between foreach ($array as $variable) and foreach ($array as $key => $value) even though $key is not used later. It would be appreciated if you can write the test code for it.

4. 3014131_error_case_breaking.patch: Looks fine to me but aws_cloud.tokens.inc can be deleted in this patch??
5. 3014131_warning_no_white_space_after.patch: This is fine to me.
6. 3014131_error_comments_not_appear.patch: //12 digits→// 12 digits. Also, I think // @TODO comment line can be deleted (Need to get @baldwinlouie's feedback)
7. 3014131_error_inline_comment_must_end.patch: Let's start an UPPER case at the beginning of the comment; put one space after //. Please put a period (.) in a header like // Updated YYYY/mm/dd <username>

By the way, FYI I think the patch name should be [description]-[issue-number]-[comment-number].patch .

ERROR | Inline comments must end in full-stops, exclamation | | marks, colons, question marks, or closing parentheses

Sorry, I mistake the uploaded patch. Correct one is attach on #17

ERROR | Closing parenthesis of array declaration must be on a new line

ERROR | Missing function doc comment

Apply comment #14

3014131_except_php_files.patch: I'm concerned to delete JS file(s) such as cloud.auto_refresh_list_all_instances.js as future reference.
→ I mean that we should leave the one(s) as it is? (I want to get @baldwinlouie's feedback

Previous patch name is "3014131_error_case_breaking.patch"

Apply the comment.

3014131_error_case_breaking.patch: Looks fine to me but aws_cloud.tokens.inc can be deleted in this patch??

Previous patch name is "3014131_error_comments_not_appear.patch"

Apply comment.

3014131_error_comments_not_appear.patch: //12 digits→// 12 digits. Also, I think // @TODO comment line can be deleted (Need to get @baldwinlouie's feedback)

3014131_error_inline_comment_must_end.patch: Let's start an UPPER case at the beginning of the comment; put one space after //. Please put a period (.) in a header like // Updated YYYY/mm/dd

Add unit test case for the modification.

3014131_warning_unused_variable.patch: I'm not confident whether the following change is really valid or not in the patch.
→ I understand that waning by the tool, however I meant that I wanted you to make sure if it makes the same result in the following code since it is different in PHP between foreach ($array as $variable) and foreach ($array as $key => $value) even though $key is not used later. It would be appreciated if you can write the test code for it.

Cleaned up the existing (old) patches

@shidat
@xiaohua-guan

We reviewed the patches. I'll merge the ones. Thank you for your contributions.

@shidat

After I applied the following patches successfully, I couldn't apply error_inline_comment_must_end-3014131_22.patch and 3014131_warning_unused_use_statement.patch.

• error_closing_parenthesis_of_array_3014131_17.patch
• error_missing_function_doc-3014131_18.patch
• except_php_files-3014131_19.patch
• error_case_breaking-3014131_20.patch
• error_comments_not_appear-3014131_21.patch
• warning_unused_variable-3014131_23.patch

Could you please make it work again?

I modified the patch files. They can be applied now. Please try the new patch files.

> I couldn't apply error_inline_comment_must_end-3014131_22.patch and 3014131_warning_unused_use_statement.patch.

@shidat
@xiaohua-guan

I reviewed the patches and looks fine. Thank you for your fixes. I'll merge the following ones.

• error_inline_comment_must_end-3014131-33.patch and
• warning_unused_use_statement-3014131-34.patch

Please let us close this issue once. Let's create another issue for further fixes.