Update CHANGELOG.txt

CommentFileSizeAuthor
#6 3010613-5.patch4.54 KByas
#4 3010613-4.patch4.54 KByas
#2 3015521-2.patch4.37 KByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Active » Needs review
FileSize
3015521-2.patch4.37 KB
baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Needs work

Here's my only comment on the patch.

+++ b/CHANGELOG.txt
@@ -1,36 +1,112 @@
+- Can't remove exiting AWS Cloud Image.

Should be existing, not exiting

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3010613-4.patch4.54 KB

@baldwinlouie,

Nice catch! Thank you for your review. Could you please check it again?

Status: Needs review » Needs work

The last submitted patch, 4: 3010613-4.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3010613-5.patch4.54 KB

Re-rolling it.

Status: Needs review » Needs work

The last submitted patch, 6: 3010613-5.patch, failed testing. View results

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs work » Reviewed & tested by the community

Looks good!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

@baldwinlouie

Thank you for your review. I merged the patch.

  • yas committed 9e2d7f2 on 8.x-1.x 
    Issue #3015521 by yas, baldwinlouie: Update CHANGELOG.txt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.