The label 'Send status' confusing the users. Either we need to update label as 'Send status/Subscribers' or display number of emails sent by newsletter. Currently, after newsletter sent, it still showing the number of users subscription.

Bugs in counts

Also noticed that the counts are wrong

And also pending count is completely wrong on NodeTabForm (/node/XX/simplenews). New patch fixes both, sharing code in a new function.

Proposed solution

Whatever the newsletter status, the output of the "send status" field should be SS/TT where SS = count of sent and TT = count of total. This should make it clear what the numbers mean.

CommentFileSizeAuthor
#12 simplenews.newsletter-status.3030432-interdiff-9-12.txt4.71 KBAdamPS
#12 simplenews.newsletter-status.3030432-12.patch10.55 KBAdamPS
#9 simplenews.newsletter-status.3030432-interdiff-7-9.txt4.11 KBAdamPS
#9 simplenews.newsletter-status.3030432-9.patch10.58 KBAdamPS
#7 simplenews.newsletter-status.3030432-7.patch6.57 KBAdamPS
#4 simplenews-list-3030432-4.patch1.06 KBneeraprajapati
#2 added-correct-label-3030432-2.patch1.11 KBGGH
Screenshot_2019-02-04 Newsletters listpage.png24.58 KBramreddy.kancherla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ramreddy.kancherla created an issue. See original summary.

GGH’s picture

GGH CreditAttribution: GGH commented
Status: Active » Needs review
FileSize
added-correct-label-3030432-2.patch1.11 KB

changed it to 'Send status(Subscribers count)'

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs review » Needs work

I think the label needs to be short - 1 or 2 words.

What is the problem exactly? Before sending the column shows number of subscribers it will go to. After sending it show number sent with a tick. Probably it can also show a partly complete sending.

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
FileSize
simplenews-list-3030432-4.patch1.06 KB

Please review applied patch.

neeraprajapati’s picture

neeraprajapati CreditAttribution: neeraprajapati at Valuebound commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: simplenews-list-3030432-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Title: Simplenews list page confusing label » Simplenews list page confusing "send status"
Issue summary: View changes
Status: Needs work » Needs review
FileSize
simplenews.newsletter-status.3030432-7.patch6.57 KB

I think the problem is not really with the label but with the data presented. Here is a new patch that alters that, and also fixes some bugs that I discovered.

Status: Needs review » Needs work

The last submitted patch, 7: simplenews.newsletter-status.3030432-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Title: Simplenews list page confusing "send status" » Simplenews list page confusing/wrong "send status"
Issue summary: View changes
Status: Needs work » Needs review
FileSize
simplenews.newsletter-status.3030432-9.patch10.58 KB
simplenews.newsletter-status.3030432-interdiff-7-9.txt4.11 KB
AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Issue tags: +Plan to commit
AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs review » Needs work
Issue tags: -Plan to commit

I'm going to alter this patch slightly

  • instead of creating simplenews_newsletter_summary it should be SpoolStorage::issueSummary
  • I plan to keep the subscribers field = "number configured to send" because I see a valid distinction from the sent field = "number actually sent".
AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs work » Needs review
FileSize
simplenews.newsletter-status.3030432-12.patch10.55 KB
simplenews.newsletter-status.3030432-interdiff-9-12.txt4.71 KB

Status: Needs review » Needs work

The last submitted patch, 12: simplenews.newsletter-status.3030432-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs work » Needs review
Issue tags: +Plan to commit

Test fails are unrelated.

  • 7ad6915 committed on 8.x-1.x 
    Issue #3030432 by AdamPS, neeraprajapati, GGH, ramreddy.kancherla:...
AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs review » Fixed
Issue tags: -Plan to commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.