Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#12 capitalize-the-module-name-3050890-12.patch5.01 KBrpsu
#8 capitalize-the-module-name-3050890-8.patch4.6 KBapaderno
#5 with_patch_registration_code.png22.13 KBkrina.addweb
#5 without_patch_registration_code.png22.35 KBkrina.addweb
#4 Screen Shot 2019-04-25 at 7.02.46 PM.png22.21 KBalonaoneill
#2 regcode_simple-info-3050890-2.patch408 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
regcode_simple-info-3050890-2.patch408 bytes

I uploaded a patch that Capitalize the name of the module in the .info.yml file.
Thanks!

Status: Needs review » Needs work

The last submitted patch, 2: regcode_simple-info-3050890-2.patch, failed testing. View results

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs work » Needs review
FileSize
Screen Shot 2019-04-25 at 7.02.46 PM.png22.21 KB

The name of the module is now capitalized on the Extend page. Screenshot provided
Please review

krina.addweb’s picture

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
without_patch_registration_code.png22.35 KB
with_patch_registration_code.png22.13 KB

@alonaoneill, Thanks for the patch. Your patch is working fine as I tested mentioned changes using simplytest.me over Extend page. PFA

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

To give more context: User interface standards / Interface text (Module and theme names) says that module and theme names should use title case capitalization.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu at Exove commented
Status: Reviewed & tested by the community » Needs work

The patch fixes module name, but not tests - which breaks the tests (as seen above).

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Needs review
FileSize
capitalize-the-module-name-3050890-8.patch4.6 KB

I corrected the module name in all the files, including code and tests.

Status: Needs review » Needs work

The last submitted patch, 8: capitalize-the-module-name-3050890-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

It doesn't seem the failure is caused from the module name change.

Drupal\Tests\regcode_simple\Functional\RegcodeSimpleCodeRegexTest::testCodePlainText
mkdir(): File exists

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu at Exove commented

Let's try to re-run the tests. #3052856: Fix linter issues (DCS, PHP 7) probably has fixed the issues with linter.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu at Exove commented
FileSize
capitalize-the-module-name-3050890-12.patch5.01 KB

Let's try again, patch is now rebuilt against current HEAD.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu at Exove commented
Status: Needs work » Needs review

  • rpsu committed fdafa65 on 8.x-1.x 
    Issue #3050890 by alonaoneill, rpsu, kiamlaluno, krina.addweb:...
rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu at Exove commented
Status: Needs review » Fixed

Patch committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.