It seems that there are a couple places where Drupal variable 'faq_path' should be used instead of hardcoded FAQ path 'faq-page'. However, since I only have limited time, so the patch I provided only fixes one place for the breadcrumb.

Please check attached patch file for details. Thanks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

deminy created an issue. See original summary.

marcaddeo’s picture

Here's an additional patch for the hardcoded faq-page path. Like OP, I only fixed it in the place that was causing problems for me due to limited time.

marcaddeo’s picture

marcaddeo’s picture

dadderley’s picture

Here is an instance of 'Drupal variable 'faq_path' should be used instead of hardcoded FAQ path 'faq-page''

I wish to use the functionality - 'Clicking on category opens/hides questions and answers under category' with the accordion effect. When I use a path for the FAQ other than 'faq-page', it does not work. When I use the path 'faq-page'. the functionality works just fine.

This issue is mentioned here Category accordion fails to collapse/expand contained questions/answers (https://www.drupal.org/node/1264968).
Stella identifies the problem here https://www.drupal.org/node/1264968#comment-5562650.

The issue is marked as fixed in dev version, but it is not.

marcelovani’s picture

Version: 7.x-1.1 » 7.x-2.x-dev
Status: Active » Needs review
FileSize
19.2 KB

I think the hard coded string should be replaced with a function that returns the configuration.

All mentions of 'faq-page' should call the function instead. Attaching the patch.

Another solution would be not using the patches from this issue and use the redirect module to redirect faq-page to whatever we want.

marcelovani’s picture

Prashant.c’s picture

Modified the changes in existing patch.
Assigned variable to multiple calls of _faq_path() function.

Submitting modified patch and interdiff file.

andrey.troeglazov’s picture

Issue tags: +FAQ Release 7.x-1.2
andrey.troeglazov’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
andrey.troeglazov’s picture

Status: Needs review » Fixed

  • andrey.troeglazov committed ef728eb on 7.x-1.x
    Issue #2623326 by marcaddeo, marcelovani, Prashant.c, andrey.troeglazov...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.