Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It seems that there are a couple places where Drupal variable 'faq_path' should be used instead of hardcoded FAQ path 'faq-page'. However, since I only have limited time, so the patch I provided only fixes one place for the breadcrumb.
Please check attached patch file for details. Thanks
Comment | File | Size | Author |
---|---|---|---|
#10 | faq-fix-hardcoded-path-7.x-1.x-2623326-9.patch | 20.04 KB | andrey.troeglazov |
| |||
#4 | faq-fix-hardcoded-path-7.x-1.1.patch | 713 bytes | marcaddeo |
faq.7.x-1.1.patch | 717 bytes | deminy | |
Comments
Comment #2
marcaddeo CreditAttribution: marcaddeo commentedHere's an additional patch for the hardcoded faq-page path. Like OP, I only fixed it in the place that was causing problems for me due to limited time.
Comment #3
marcaddeo CreditAttribution: marcaddeo commentedComment #4
marcaddeo CreditAttribution: marcaddeo commentedComment #5
dadderley CreditAttribution: dadderley as a volunteer commentedHere is an instance of 'Drupal variable 'faq_path' should be used instead of hardcoded FAQ path 'faq-page''
I wish to use the functionality - 'Clicking on category opens/hides questions and answers under category' with the accordion effect. When I use a path for the FAQ other than 'faq-page', it does not work. When I use the path 'faq-page'. the functionality works just fine.
This issue is mentioned here Category accordion fails to collapse/expand contained questions/answers (https://www.drupal.org/node/1264968).
Stella identifies the problem here https://www.drupal.org/node/1264968#comment-5562650.
The issue is marked as fixed in dev version, but it is not.
Comment #6
marcelovaniI think the hard coded string should be replaced with a function that returns the configuration.
All mentions of 'faq-page' should call the function instead. Attaching the patch.
Another solution would be not using the patches from this issue and use the redirect module to redirect faq-page to whatever we want.
Comment #7
marcelovaniPatch for 7.x-1.x
Comment #8
Prashant.cModified the changes in existing patch.
Assigned variable to multiple calls of _faq_path() function.
Submitting modified patch and interdiff file.
Comment #9
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #10
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #11
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #12
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented