When selecting more than allowed items in the media library popup a form error message appears: 

You can not select more than 1 entity.

When inline form errors is enabled, an error appears: 1 error has been found: Select this item

This error is not useful and seems to be introduced here: https://www.drupal.org/project/drupal/issues/2962525

CommentFileSizeAuthor
#8 2998066-disable-inline-form-errors.patch529 bytesDave Reid
#3 2998066_3.patch529 bytesmpp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpp created an issue. See original summary.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Status: Active » Needs review
FileSize
2998066_3.patch529 bytes

Added patch to disable inline form errors.

Before:

1 error has been found: Select this item

After:

You can not select more than 1 entity.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Project: Drupal core » Entity Browser
Version: 8.8.x-dev » 8.x-2.x-dev
Component: media system » Core API
zero2one’s picture

zero2one CreditAttribution: zero2one at Serial Graphics for District09 commented
Status: Needs review » Reviewed & tested by the community

Tested patch #3 : works for me.

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented

Looks good! Thank you.

@mpp you might want to check the patch naming conventions.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

It looks like this needs a re-roll. Tests would be helpful too.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Needs work » Needs review
FileSize
2998066-disable-inline-form-errors.patch529 bytes

The patch does cleanly apply, it's just that the project was changed, and before it was trying to apply the patch to Drupal Core, not Entity Browser. So re-uploading

smulvih2’s picture

smulvih2
Location Canada 🍁
CreditAttribution: smulvih2 at Cinder Systems Corp., Health Canada - HPFB commented

Patch #8 works for me.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Reviewed & tested by the community

+1 for this

  • Dave Reid committed 8d1fd965 on 8.x-2.x 
    Issue #2998066 by mpp, Dave Reid: Field widget for the Media library is...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Reviewed & tested by the community » Fixed

Committed #8 to 8.x-2.x. Thanks all!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

@Dave Reid, thanks for this, could you also please tag a release?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented

Yup, I am working on reviewing the RTBC queue still.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented

Isn't this a bit overdoing to disable inline form errors in general when the issue is only about a specific field widget?