Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Replace deprecated usage of url()
and urlInfo()
Comment | File | Size | Author |
---|---|---|---|
#23 | interdiff-20-23.txt | 5.26 KB | aleevas |
#23 | 3066861-23.patch | 15.58 KB | aleevas |
| |||
#14 | 3066861-14-intediff.txt | 1.09 KB | rpayanm |
#12 | 3066861-12.patch | 15.03 KB | rpayanm |
#12 | 3066861-12-intediff.txt | 2.17 KB | rpayanm |
Comments
Comment #2
Satyanarayan Reddy CreditAttribution: Satyanarayan Reddy at Melity commentedApply patch deprecated usage
Comment #3
penyaskito@Satyanarayan Reddy Thanks!!!
Comment #4
penyaskitoComment #5
penyaskitoWe are missing url(), let's do those in the same patch
Comment #7
penyaskitoLet's add credit to @Munavijayalakshmi who worked on #2875917: Replace deprecated entity->urlInfo() method with entity->toUrl()., and let's use this issue instead of that one.
Comment #8
aleevasHere is my patch.
It includes changes for both deprecated functions:
url()
andurlInfo()
Comment #10
rpayanmComment #12
rpayanmComment #14
rpayanmComment #16
rpayanmComment #18
aleevasHere is my patch
Comment #19
aleevasNext turn :)
Comment #20
aleevasNever mind, keep doing...
(I'm just lazy to properly configure the phpunit stuff :)
Comment #21
aleevasComment #22
penyaskitoThis looks great, thanks!
Only a couple of change requests:
For backwards compatibility, $url_generator should be NULL by default and we should trigger an error.
Like:
Same here.
Comment #23
aleevas@penyaskito
here my fixed patch
Comment #25
penyaskitoThat looks really good, thanks! Re-testing as those test errors are unrelated.
Comment #26
penyaskitoCommitted 46920a6 and pushed to 8.x-2.x. Thanks all involved!