Problem/Motivation

The route for the configuration link is wrong and gives a page not found.

Proposed resolution

Fix the route.

Remaining tasks

Provide patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

Fix configuration link.

CommentFileSizeAuthor
#3 Screen Shot 2019-07-29 at 1.53.59 PM.png43.69 KBalonaoneill
#2 3071163-2.patch376 bytestim-diels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Decency commented
Status: Active » Needs review
FileSize
3071163-2.patch376 bytes

Please review patch.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
FileSize
Screen Shot 2019-07-29 at 1.53.59 PM.png43.69 KB

Patch looks good to me, but you need to remove extra space.

+++ b/mailjet.routing.yml
@@ -1,5 +1,5 @@
+  path: '/admin/config/system/mailjet'  ¶

Remove an extra space in line 3

Also I can't enable the module on Extend page. After I applied patch via Simplytest.me it showed me that PHPMailer Library, which is missing.
I added the screenshot with it. Do you know why it happens?

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Decency commented

That extra spaces will need to be fixed in different issue (#3071238: To much spaces in routing file) as this is for all the lines in that file.
As for the PHPMailer Library that is missing, I'll try to sort that out later today.

Mailjet Plugins’s picture

Mailjet Plugins CreditAttribution: Mailjet Plugins commented
Assigned: Unassigned » Mailjet Plugins
Mailjet Plugins’s picture

Mailjet Plugins CreditAttribution: Mailjet Plugins commented
Status: Needs review » Fixed

Hi, thank you for providing this patch. The issue has been fixed in version 8.x-2.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.