In the controller and form files, We should use dependency injection.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anmolgoyal74 created an issue. See original summary.

ravi.shankar’s picture

Status: Active » Needs review
FileSize
5.74 KB

I have fixed.

anmolgoyal74’s picture

Status: Needs review » Needs work
-    $entityManager = \Drupal::service('entity_field.manager');
+    $entityManager = $this->entityFieldManager;

Need to change the variable name.

ravi.shankar’s picture

Status: Needs work » Needs review
FileSize
6.38 KB

I have modified.

anmolgoyal74’s picture

Status: Needs review » Needs work

Patch not able to apply.

ravi.shankar’s picture

Status: Needs work » Needs review
FileSize
6.38 KB

It's applying for me.

anmolgoyal74’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.