Drupal 9 code deprecation / readiness / compatibility

Here is the patch, please review.

@sergiu-stici

I'll take over this issue.

Fixing the issue by adding ->toString on Link::fromTextAndUrl(...).

@all

The Drupal CI/CD system doesn't work for the 8.x-2.x automate testing, but the tests for 8.x-1.x have been passed successfully, so I'll merge the patch to 8.x-1.x and 8.x-2.xand close this issue as Fixed.

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing title and tag cleanup here based on that discussion.

@kristen-pol

Thank you for your follow-up!

@all

I fixed the following errors to be compatible with Drupal 9.0.0

------ ---------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/KeyPair.php  
 ------ ---------------------------------------------------------------------- 
  113    Call to deprecated function file_directory_temp():                    
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                 
         \Drupal\Core\File\FileSystemInterface::getTempDirectory() instead.    
  114    Call to deprecated function file_directory_temp():                    
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                 
         \Drupal\Core\File\FileSystemInterface::getTempDirectory() instead.    
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/k8s/src/Entity/K8sNodeViewBuilder.php  
 ------ ----------------------------------------------------------------------- 
  240    Call to deprecated function format_date():                             
         in drupal:8.0.0 and is removed from drupal:9.0.0.                      
         Use \Drupal::service('date.formatter')->format().                      
  241    Call to deprecated function format_date():                             
         in drupal:8.0.0 and is removed from drupal:9.0.0.                      
         Use \Drupal::service('date.formatter')->format().                      
------ ----------------------------------------------------------------------- 

------ -------------------------------------------------------------------------------------------------------- 
  Line   src/Form/Config/CloudAdminSettings.php                                                                  
 ------ -------------------------------------------------------------------------------------------------------- 
  111    Call to deprecated method getUrlGenerator() of class Drupal\Core\Form\FormBase:                         
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                                       
         Use the url_generator service instead.                                                                  
  111    Class Symfony\Cmf\Component\Routing\VersatileGeneratorInterface not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------------   

1. EntityManagerInterface::getDefinition() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityTypeManager::getDefinition() instead. See https://www.drupal.org/node/2549139 60x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 45x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config
2. EntityManagerInterface::getStorage() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityTypeManager::getStorage() instead. See https://www.drupal.org/node/2549139 94x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 6x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 4x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
3. EntityManagerInterface::getFieldStorageDefinitions() is deprecated in drupal:8.0.0 and will be removed before drupal:9.0.0. Use \Drupal\Core\Entity\EntityFieldManagerInterface::getFieldStorageDefinitions() instead. See https://www.drupal.org/node/2549139. 21x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 20x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 20x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
4. Passing the entity repository service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 38x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
5. Passing the language manager service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 38x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
6. Passing the entity type manager service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 38x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
7. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\SecurityGroupViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
8. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Vpc\SubnetViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
9. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Vpc\VpcViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
10. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\ImageViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
11. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\KeyPairViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
12. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\NetworkInterfaceViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
13. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\SnapshotViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
14. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\VolumeViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
15. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\InstanceViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
16. The property entityManager (entity.manager service) is deprecated in Drupal\aws_cloud\Entity\Ec2\ElasticIpViewsData and will be removed before Drupal 9.0.0. 3x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 2x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
17. Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use. 1x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
18. Any entity_reference_autocomplete component of an entity_form_display must have a match_limit setting. The uid field on the cloud_config.aws_ec2.default form display is missing it. This BC layer will be removed before 9.0.0. See https://www.drupal.org/node/2863188 1x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
19. Any entity_reference_autocomplete component of an entity_form_display must have a match_limit setting. The uid field on the cloud_server_template.aws_cloud.default form display is missing it. This BC layer will be removed before 9.0.0. See https://www.drupal.org/node/2863188 1x in AwsCloudConfigTest::testCloudConfig from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config 1x in AwsCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\aws_cloud\Functional\Config
20. EntityType::getLowercaseLabel() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, you should call getSingularLabel(). See https://www.drupal.org/node/3075567 1x in AwsCloudConfigTest::testCloudConfigBulk from Drupal\Tests\aws_cloud\Functional\Config
21. EntityManagerInterface::getDefinition() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityTypeManager::getDefinition() instead. See https://www.drupal.org/node/2549139 646x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config 8x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config
22. EntityManagerInterface::getStorage() is deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityTypeManager::getStorage() instead. See https://www.drupal.org/node/2549139 22x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 12x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
23. Passing the entity type manager service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 10x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 4x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
24. Passing the entity repository service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 10x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 4x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
25. Passing the language manager service to \Drupal\views\Plugin\views\field\LinkBase::__construct is required since 8.7.0, see https://www.drupal.org/node/3023427. 10x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 4x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
26. EntityType::getLowercaseLabel() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, you should call getSingularLabel(). See https://www.drupal.org/node/3075567 3x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
27. Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use. 1x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 1x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
28. Any entity_reference_autocomplete component of an entity_form_display must have a match_limit setting. The uid field on the cloud_server_template.k8s.default form display is missing it. This BC layer will be removed before 9.0.0. See https://www.drupal.org/node/2863188 1x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 1x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
29. Any entity_reference_autocomplete component of an entity_form_display must have a match_limit setting. The uid field on the cloud_config.k8s.default form display is missing it. This BC layer will be removed before 9.0.0. See https://www.drupal.org/node/2863188 1x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\Config 1x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\Config
30. Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was Drupal\aws_cloud\Entity\Ec2\ElasticIpViewBuilder::removeFieldsExceptLabelField. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725 6x in ElasticIpTest::testUpdateElasticIpList from Drupal\Tests\aws_cloud\Functional\Ec2 3x in ElasticIpTest::testElasticIp from Drupal\Tests\aws_cloud\Functional\Ec2
31. Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was Drupal\aws_cloud\Entity\Ec2\ImageViewBuilder::build. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725 3x in ImageTest::testImage from Drupal\Tests\aws_cloud\Functional\Ec2 3x in ImageTest::testUpdateImageList from Drupal\Tests\aws_cloud\Functional\Ec2 1x in ImageTest::testImportImage from Drupal\Tests\aws_cloud\Functional\Ec2
32. Remaining deprecation notices (3) 3x: Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was Drupal\k8s\Entity\K8sNamespaceViewBuilder::build. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725 3x in K8sNamespaceTest::testNamespace from Drupal\Tests\k8s\Functional
33. Remaining deprecation notices (9) 9x: Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was aws_cloud_server_template_reorder. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725 3x in InstanceExtraTest::testUpdateInstanceAttributes from Drupal\Tests\aws_cloud\Functional\Ec2 3x in InstanceExtraTest::testInstanceTerminateConfiguration from Drupal\Tests\aws_cloud\Functional\Ec2 3x in InstanceExtraTest::testCreateInstanceWithScheduleTag from Drupal\Tests\aws_cloud\Functional\Ec2
34. Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was aws_cloud_server_template_reorder. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725 6x in InstanceTest::testLaunchValidation from Drupal\Tests\aws_cloud\Functional\Ec2 3x in InstanceTest::testInstance from Drupal\Tests\aws_cloud\Functional\Ec2 3x in InstanceTest::testImageCreationFromInstance from Drupal\Tests\aws_cloud\Functional\Ec2 1x in InstanceTest::testUpdateInstances from Drupal\Tests\aws_cloud\Functional\Ec2

I checked all tests (above screenshots) and it should be fine.

@yas, the patch looks good

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-2.x and close this issue as Fixed.