Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-5-6.txt | 1.07 KB | idebr |
#5 | 3071739.patch | 7.17 KB | mkalkbrenner |
#4 | search-api-incompatible-version.png | 41.79 KB | idebr |
Comments
Comment #2
idebr CreditAttribution: idebr at ezCompany commentedIs this issue specifically for the changes to search_api_solr_defaults tests currently included in #3042605-5: Drupal 9 Deprecated Code Report?
Comment #3
mkalkbrennerYou gave the starting point but unfortunately it is more than this :-(
I created a branch on github: https://github.com/mkalkbrenner/search_api_solr/tree/3042605
And a PR: https://github.com/mkalkbrenner/search_api_solr/pull/46
It contains the drupal 9 deprecation things and a lot of fixes for the tests. But the tests still fail on travis. Help is appreciated!
Comment #4
idebr CreditAttribution: idebr at ezCompany commented\Drupal\Tests\search_api_solr_defaults\Functional\IntegrationTest tries to install the 'Solr Search Defaults' module through the Extend (admin/modules ) page. This page shows
This is caused by this line in .travis.yml:59, since -dev version do not include a version number
composer require drupal/search_api:1.x-dev
There are a few ways to work around this:
Comment #5
mkalkbrennerThanks for your input!
We already use composer_deploy. But you're right, it's not used in this Integration test.
Comment #6
idebr CreditAttribution: idebr at ezCompany commentedThis interdiff to https://github.com/mkalkbrenner/search_api_solr/pull/46 fixed the errors for me locally.
Comment #7
idebr CreditAttribution: idebr at ezCompany commentedComment #8
mkalkbrennerThanks, that helped.
But there were more things required to get it to work on travis. The test now passes until the index should be deleted:
I wonder why that passes on your local environment?
(Note that the PR on github has new code.)
Comment #10
mkalkbrennerSo the essential stuff of the test is working again and will now be tested on travis on every run.
But we still have a failure I mentioned in #8 which I skipped now in the test code to not block the release.
Comment #11
mkalkbrennerComment #12
idebr CreditAttribution: idebr at ezCompany commentedI probably had a different version of your PR. I'm still getting used to working with remote branches.
Anyway, to fix the failure you mentioned in #8:
Add a line after this:
\Drupal\Core\Test\FunctionalTestSetupTrait::resetAll
Comment #13
mkalkbrennerGreat, that seems to fix it: https://travis-ci.org/mkalkbrenner/search_api_solr/builds/567861275
Comment #15
mkalkbrennerComment #16
idebr CreditAttribution: idebr at ezCompany commentedLove it, nice work!