No composer.json file is provided and Mobile Detect library is included as a file instead of providing an option to downloading the latest library. This will leave this module with bugs if there is any update in Mobile Detect library.

CommentFileSizeAuthor
#3 3074839-3.patch71.08 KBsarathkm
#2 3074839-2.patch1.81 KBsarathkm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sarathkm created an issue. See original summary.

sarathkm’s picture

sarathkm
Sapiens
Primary language English
Location Bengaluru, Karnataka
CreditAttribution: sarathkm at Valuebound commented
Assigned: sarathkm » Unassigned
Status: Active » Needs review
FileSize
3074839-2.patch1.81 KB
sarathkm’s picture

sarathkm
Sapiens
Primary language English
Location Bengaluru, Karnataka
CreditAttribution: sarathkm at Valuebound commented
FileSize
3074839-3.patch71.08 KB
dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
Assigned: Unassigned » dhanlal
dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
Assigned: dhanlal » Unassigned
Status: Needs review » Reviewed & tested by the community 
git apply -v 3074839-3.patch
Checking patch composer.json...
Checking patch mobile_detect_twig_extensions.services.yml...
Checking patch src/Detect/MobileDetect.php...
Checking patch src/Detect/Mobile_Detect.php...
Checking patch src/Twig/MobileDetectExtension.php...
Applied patch composer.json cleanly.
Applied patch mobile_detect_twig_extensions.services.yml cleanly.
Applied patch src/Detect/MobileDetect.php cleanly.
Applied patch src/Detect/Mobile_Detect.php cleanly.
Applied patch src/Twig/MobileDetectExtension.php cleanly.
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Status: Reviewed & tested by the community » Needs review

ghanlal,
Thanks for engaging with the community.

However: Please don't mark an issue "Reviewed and Tested By the Community" (RTBC) if you haven't tested the actual changes and that they work. Checking that the patch applies is not enough to know if the patch solves the actual issue.

Please read: https://www.drupal.org/node/1839650

Changing status.

nonom’s picture

nonom CreditAttribution: nonom as a volunteer commented

Reviewing the patch and commiting, thanks for contributing!

nonom’s picture

nonom CreditAttribution: nonom as a volunteer commented
Version: 8.x-1.x-dev » 8.x-1.0
Assigned: Unassigned » nonom
Status: Needs review » Fixed

  • nonom committed 81761a0 on 8.x-1.x authored by sarathkm 
    Issue #3074839 by sarathkm, dhanlal, gisle: Add composer.json file and...
nonom’s picture

nonom CreditAttribution: nonom as a volunteer commented
Status: Fixed » Closed (fixed)
nonom’s picture

nonom CreditAttribution: nonom as a volunteer commented
Status: Closed (fixed) » Fixed
nonom’s picture

nonom CreditAttribution: nonom as a volunteer commented
Status: Fixed » Closed (fixed)