Update drupal/coder to 8.3.6

This needs to be created against 8.8.x. I just released Coder 8.3.6, so we should update to that.

Patch, includes some minor fixes that Coder would flag now.

I hd to move around some @code sections because Coder would think they belong to the @param comment. However, general example docs about a function should be above param docs anyway.

Running `composer phpcs` locally with drupal/coder 8.3.6 results in a large number of reports regarding the \Drupal\Sniffs\Commenting\VariableCommentSniff:

FILE: .../d8/core/modules/views/tests/src/Kernel/Handler/FieldUrlTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------

Was this sniff updated between 8.3.4 and 8.3.6? If so, should its fix be included in this issue?

Yes, VariableCommentSniff was updated in #2909393: Find missing comments for member variables. This sniff is disabled in core in phpcs.xml.dist, so does not affect this update.

Can you run the following and verify that the output of PHPCS is empty? (Adjust installed_paths to your local path)

./vendor/bin/phpcs --config-set installed_paths /var/www/html/vendor/drupal/coder/coder_sniffer/
cd core
../vendor/bin/phpcs

Thanks!

Closed #3074773: Updating drupal/coder (8.3.4 => 8.3.6): composer.lock as a duplicate issue.

#7 Actually Drupal.Commenting.VariableComment is enabled in core/phpcs.xml.dist. That means the new 'Missing' that was added in #2909393: Find missing comments for member variables has to be disabled for the existing code to pass. I have updated core/phpcs.xml.dist accordingly.

Ah, good point, thank you!

I did not know about running "composer phpcs", that is useful! Output from that does not report errors with this patch after running composer install, so we should be good here.

I had to run it as "COMPOSER_PROCESS_TIMEOUT=10000 composer phpcs -- -p" to work around the composer timeout, we should disable that for phpcs with https://getcomposer.org/doc/06-config.md#process-timeout in a separate issue.

+++ b/core/includes/batch.inc
@@ -364,7 +364,7 @@ function _batch_process() {
-    $message = strtr($progress_message, $values);
+    $message    = strtr($progress_message, $values);

is this change required?

Yes, there was a fix in coder that flags this now.

Committed 0192048 and pushed to 8.8.x. Thanks!