Some part of the code like here, drupal service is being called try using dependency injection instead of that.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pallavisk created an issue. See original summary.

Pavan B S’s picture

I will be working on this issue

Pavan B S’s picture

FileSize
1.65 KB

Made changes as suggested please review

pallavisk’s picture

Status: Active » Needs review
pratik_kamble’s picture

Assigned: Unassigned » pratik_kamble
pratik_kamble’s picture

@pavan-b-s I have reviewed your patch you have added unneeded config_factory variable at line no. 19. Also, no documentation is added to the class variable.
I have attached new patch which contains the Dependency Injection.

pratik_kamble’s picture

Assigned: pratik_kamble » Unassigned
ambuj_gupta’s picture

Tested and verified the module after adding the patch created by @pratik_kamble. And it is working as expected.

ambuj_gupta’s picture

Status: Needs review » Reviewed & tested by the community
Lal_’s picture

Status: Reviewed & tested by the community » Fixed

good fix

Lal_’s picture

Lal_’s picture

pratik_kamble’s picture

Status: Fixed » Closed (fixed)