Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Basic GDPR Compliance use cases:
- Form checkboxes
- Pop-up alert
- Policy Page
Project link
https://www.drupal.org/project/gdpr_compliance
Git instructions
git clone --branch 8.x-1.x https://git.drupalcode.org/project/gdpr_compliance.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-gdpr_compliance
Comments
Comment #2
ivnish CreditAttribution: ivnish commentedPlease fix pareview warnings first
Comment #3
APolitsin CreditAttribution: APolitsin commentedFix codestyle problems in css and js files.
Cannot fix `Error - Use the function form of 'use strict'. ` couse i need this staff.
Comment #4
apadernoThank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.
Comment #5
vuilThank you for the contribution!
I have found many security related issues (errors/warnings/notices), please fix all of them.
(1.)
Please fix the following issues related to ESLint, there are some issues within the code (please check the JavaScript coding standards):
(2.)
Please don't use dynamically created properties like
$this->lang
in PagePolicy class.Just declare them at first (into the Class), then initialize them in
__construct()
, and use them after that.It is important your code to be as much as possible clear and mindful.
(3.)
Please replace the usage of
\Drupal::request()
with the Dependency Injection (DI) and$container->get('request_stack')
.(4.)
Replace the wrong and deprecated usage of
entityManager()
withentityTypeManager()
(all uses) in your Dependency Injection (DI) andSettingsFormWarning
class.(5.)
Always keep attention on your configuration forms input secure and Sanitizing Output, read more https://www.drupal.org/docs/8/security
Update texts to use the more secure:
Url::fromRoute('Some text @param', ['param' => $param_url])->toString();
instead of plain text:
/user/register
and/user/login
.An example:
Url::fromRoute('entity.node.canonical', ['node' => $next['nid']])->toString();
Comment #6
KuldeepM CreditAttribution: KuldeepM commentedFix Error - Use the function form of 'use strict'. (strict) issue.
Comment #7
klausiThanks for your contribution!
Looks good to me, did not see a security issue.
Comment #8
apadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.