Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It is impossible to set such kind of text for @deprecated comment:
* @deprecated in project:8.x-1.0-beta3 and will be removed from project:8.x-1.0-rc1.
only exact versions are allowed, like this
* @deprecated in project:8.x-1.0 and will be removed from project:8.x-2.0.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff-7-5.txt | 2.37 KB | LOBsTerr |
#8 | deprecate-text-custom-release-3074947-7.patch | 2.37 KB | LOBsTerr |
#5 | deprecate-text-custom-release-3074947-5.patch | 1.68 KB | LOBsTerr |
#5 | interdiff-2-5.txt | 1.75 KB | LOBsTerr |
#2 | deprecate-text-custom-release-3074947-2.patch | 1.66 KB | LOBsTerr |
Comments
Comment #2
LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commentedFeel free to propose cleaner messages and comments
Comment #3
Dropa CreditAttribution: Dropa at Mediamaisteri Oy commentedWhile I'm not entirely sure what is the
8.x-beta3
meaning, as it for me looḱs like it is missing the branch itself, so it could be just8.x-1.0-beta3
like the standard in drupal.org.However, as a person who maintains several modules for Drupal that are not published in drupal.org and does not follow the same versioning method as standard, but uses semantic versioning directly, I'd like the sniff to allow me use
project:3.0.0
instead.I'm not going to provide patch at least for now as my approach would be different than @LOBsTerr's. For my cases, I can easily mask version number with preferred Drupal core (like
project:8.x-3.0
), just here to give my opinion on the subject.Comment #4
LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commentedComment #5
LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commented@Dropa. You are right. I have provided a new patch
Comment #6
LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commentedComment #7
klausiI think this makes sense. Can you provide test cases for your use cases and file this as pull request against https://github.com/pfrenssen/coder ?
Thanks!
Comment #8
LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commentedI have added a test case.
PR https://github.com/pfrenssen/coder/pull/60
Comment #9
Dropa CreditAttribution: Dropa at Mediamaisteri Oy commentedThe interdiff between #7 and #5 is actually the patch itself btw.
Comment #11
klausiCommitted, thanks!