It is impossible to set such kind of text for @deprecated comment:

* @deprecated in project:8.x-1.0-beta3 and will be removed from project:8.x-1.0-rc1.

only exact versions are allowed, like this

* @deprecated in project:8.x-1.0 and will be removed from project:8.x-2.0.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LOBsTerr created an issue. See original summary.

LOBsTerr’s picture

Feel free to propose cleaner messages and comments

Dropa’s picture

While I'm not entirely sure what is the 8.x-beta3 meaning, as it for me looḱs like it is missing the branch itself, so it could be just 8.x-1.0-beta3 like the standard in drupal.org.

However, as a person who maintains several modules for Drupal that are not published in drupal.org and does not follow the same versioning method as standard, but uses semantic versioning directly, I'd like the sniff to allow me use project:3.0.0 instead.

I'm not going to provide patch at least for now as my approach would be different than @LOBsTerr's. For my cases, I can easily mask version number with preferred Drupal core (like project:8.x-3.0), just here to give my opinion on the subject.

LOBsTerr’s picture

Issue summary: View changes
LOBsTerr’s picture

Status: Active » Needs work
FileSize
1.75 KB
1.68 KB

@Dropa. You are right. I have provided a new patch

LOBsTerr’s picture

Status: Needs work » Needs review
klausi’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

I think this makes sense. Can you provide test cases for your use cases and file this as pull request against https://github.com/pfrenssen/coder ?

Thanks!

LOBsTerr’s picture

Status: Needs work » Needs review
FileSize
2.37 KB
2.37 KB

I have added a test case.
PR https://github.com/pfrenssen/coder/pull/60

Dropa’s picture

The interdiff between #7 and #5 is actually the patch itself btw.

  • klausi committed 30f7e0c on 8.x-3.x authored by LOBsTerr
    fix(Deprecated): Allow non stable releases like rc, alpha in deprecated...
klausi’s picture

Status: Needs review » Fixed
Issue tags: -Needs tests

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.