The automated fixer for Drupal.Commenting.DocComment.TagGroupSpacing. doesn't work as it should, see also #2937513: Fix 'Drupal.Commenting.DocComment.TagGroupSpacing' coding standard

Comments

borisson_ created an issue. See original summary.

klausi’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Active » Closed (outdated)

This has been fixed with #3073750: @see references are special and should be allowed to be indented and other issues. I need to make a Coder release and then we can update Coder in core and continue with the core issue.

Updating Coder in core is #3063323: Update drupal/coder to 8.3.6.

idebr’s picture

Status: Closed (outdated) » Active

The sniff still produces a few false positives:

core/lib/Drupal/Core/Asset/CssOptimizer.php

Before:

   * @param array $matches
   *   An array of matches by a preg_replace_callback() call that scans for
   *   @import-ed CSS files, except for external CSS files.

After:

   * @param array $matches
   *   An array of matches by a preg_replace_callback() call that scans for
   *
   * @import-ed CSS files, except for external CSS files.

core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php

Before:

   * @param array $sub_key
   *   An array containing the sub-keys specifying the library asset, e.g.
   *   @code['js']@endcode or @code['css', 'component']@endcode

After:

   * @param array $sub_key
   *   An array containing the sub-keys specifying the library asset, e.g.
   *
   * @code['js']@endcode or @code['css', 'component']@endcode

core/lib/Drupal/Core/Mail/MailManagerInterface.php

Before:

   * @param string $to
   *   The email address or addresses where the message will be sent to. The
   *   formatting of this string will be validated with the
   *   @link http://php.net/manual/filter.filters.validate.php PHP email validation filter. @endlink

After:

   * @param string $to
   *   The email address or addresses where the message will be sent to. The
   *   formatting of this string will be validated with the
   *
   * @link http://php.net/manual/filter.filters.validate.php PHP email validation filter. @endlink

  • klausi committed c8664df on 8.x-3.x
    fix(DocComment): Fix handling of doc comment tags within tag groups (#...
klausi’s picture

Status: Active » Fixed

Thanks a lot for reporting the broken examples!

I pushed a fix that should deal with those examples.

The next step is to test the Coder dev version on core again and see if this resolves all problems now. If that is the case then we can release the next version of Coder or fix anything remaining before that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.