An origin page might have set status, warning or error messages to be displayed on the destination page. This is common when posting a form and the submit callback sets a success message. But if, in the meantime a new document version is released the message will end on the acceptance form and not on the destination page. The same happens if the login process sets such a message to be displayed after, on the first page after the login. The messages lands on the acceptance form.

CommentFileSizeAuthor
#5 3080124-5.interdiff.txt8.17 KBclaudiu.cristea
#5 3080124-5.patch29.58 KBclaudiu.cristea
#2 3080124-2.test_only.patch23.82 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3080124-2.test_only.patch23.82 KB

Here's a test to prove the bug.

Status: Needs review » Needs work

The last submitted patch, 2: 3080124-2.test_only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
3080124-5.patch29.58 KB
3080124-5.interdiff.txt8.17 KB

The fix.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. The test also presents a good use case for the kind of messages that might be shown: the website might show a welcome message to the user upon login. For example the message to inform the user that they used their one-time login message. These messages should not show up on the form to accept the legal entity.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

Adding credit.

  • claudiu.cristea committed b517060 on 8.x-2.x 
    Issue #3080124 by claudiu.cristea, pfrenssen: Pending messages should be...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Thank you for review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.