When I create a new meta entity type, and I then try to create one of the meta entities through the UI using the default settings, I am getting the following error:

Error: Call to a member function getEntityTypeId() on null
/home/pieter/v/joinup-dev/web/modules/contrib/meta_entity/src/Plugin/Validation/Constraint/MappedTargetEntityValidator.php:45

This is because in the default configuration the entity reference to the target entity is hidden from the form display, and the entity is saved without referencing the target entity. The code does not account for the fact that the reference might be empty.

CommentFileSizeAuthor
#2 3080887-2-test-only.patch1.24 KBpfrenssen
#2 3080887-2.patch2.13 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3080887-2.patch2.13 KB
3080887-2-test-only.patch1.24 KB

Here's a patch and a test.

Status: Needs review » Needs work

The last submitted patch, 2: 3080887-2-test-only.patch, failed testing. View results

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Reviewed & tested by the community

Thanks!

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Needs review

Thanks for quick review!

The test result shows the error I was encountering:

1) Drupal\Tests\meta_entity\Kernel\MappedTargetEntityConstraintTest::testConstraint
Error: Call to a member function getEntityTypeId() on null
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

  • pfrenssen committed 484ccae on 8.x-1.x 
    Issue #3080887 by pfrenssen: Fatal error when creating meta entity...
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.