Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It just struck me while working on the node revision translations that the testing of revisions post migration was a limited to one node in both the d6 and d7 tests. I thought it a good idea to test all the revisions.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3079298-2.patch | 8.2 KB | quietone |
Comments
Comment #2
quietone CreditAttribution: quietone as a volunteer commentedAnd a patch
Comment #3
quietone CreditAttribution: quietone as a volunteer commentedComment #4
mikelutzAlways a fan of more tests. :-) These look good.
Comment #5
larowlanthis looks duplicated - could it go in a trait or base class?
Comment #6
quietone CreditAttribution: quietone as a volunteer commented@larowlan, yes they could and I have thought about that more than once while working on this patch and other Migrate Kernel tests. I choose not to do it here because of precedence, we haven't been making a base class or trait for asserting an entity. The other reason is that I'd prefer that anything we do to rationalize the testing be it's own meta where we take a moment to discuss how to do it for all entities. That way we all agree and then many of the children of that can probably be a novice issue as well.
Comment #7
quietone CreditAttribution: quietone as a volunteer commentedMade an issue to consider creating common assert entity methods got the migration kernel tests. #3080745: Create common assert entity methods for migration tests
Comment #8
heddn+1 on #6. Follow-up is opened. Back to RTBC.
Comment #9
larowlanHappy with a followup
Committed d2116d6 and pushed to 8.8.x. Thanks!