Problem/Motivation

We're about to add more Twig extensions to this module and to alter existing ones and we don't have any tests. That makes it difficult to ensure we don't break stuff.

Proposed resolution

Add tests.

Remaining tasks

Write them. https://www.drupal.org/docs/8/phpunit

User interface changes

None.

API changes

NONE. And, after the tests are written, we'll know when API changes actually happen.

CommentFileSizeAuthor
#9 3082893-9.patch4.62 KBJohnAlbin
#7 3082893-7.patch2.08 KBJohnAlbin
#5 3082893-5.patch2.05 KBJohnAlbin
#3 3082893-3.patch2.09 KBJohnAlbin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin created an issue. See original summary.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Parent issue: » #2821512: Create alternative to Twig include function to improve Drupal integration
Related issues: -#2821512: Create alternative to Twig include function to improve Drupal integration
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Status: Active » Needs review
FileSize
3082893-3.patch2.09 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3082893-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Status: Needs work » Needs review
FileSize
3082893-5.patch2.05 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3082893-5.patch, failed testing. View results

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Status: Needs work » Needs review
FileSize
3082893-7.patch2.08 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3082893-7.patch, failed testing. View results

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Status: Needs work » Needs review
FileSize
3082893-9.patch4.62 KB

Finally figured out how to run tests locally. :-p

  • JohnAlbin committed 642def0 on 8.x-2.x 
    Issue #3082893 by JohnAlbin: Add unit tests for TwigExtension
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.