See attached CS suggestions text file. Mainly:
Short array syntax must be used to define arrays

CommentFileSizeAuthor
#12 3023183-12.patch19.88 KBidebr
#9 3023183-9.patch15.92 KBrpayanm
#4 code_sniffer_fixes-3023183-4.patch19.26 KBlolandese
#4 code_sniffer_best_practice_suggestions.txt3.01 KBlolandese
#3 code_sniffer_fixes-3023183-3.patch18.6 KBlolandese
#2 code_sniffer_fixes-3023183-2.patch16.82 KBlolandese
code_sniffer_suggestions.txt10.14 KBlolandese
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese CreditAttribution: lolandese as a volunteer commented
Status: Active » Needs review
FileSize
code_sniffer_fixes-3023183-2.patch16.82 KB

Attached patch applies all the automated Code Sniffer fixes.

lolandese’s picture

lolandese CreditAttribution: lolandese as a volunteer commented
FileSize
code_sniffer_fixes-3023183-3.patch18.6 KB

Attached patch additionally contains also manual corrections to come out completely "clean".

lolandese’s picture

lolandese CreditAttribution: lolandese as a volunteer commented
FileSize
code_sniffer_best_practice_suggestions.txt3.01 KB
code_sniffer_fixes-3023183-4.patch19.26 KB

Attached patch additionally contains also Code Sniffer Best Practice suggestions (see attached text file).

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Thank you lolandese for working on this. I did a manual check to confirm the changes fix all code sniffer suggestions.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Reviewed & tested by the community » Needs work

The patch can not be applied to '8.x-1.x-dev' branch. Needs work!

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Issue tags: +Needs reroll
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm as a volunteer and at Kadabra commented
Status: Needs work » Needs review
FileSize
3023183-9.patch15.92 KB

Status: Needs review » Needs work

The last submitted patch, 9: 3023183-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

AjitS’s picture

AjitS
he/him
Primary language Marathi
Location Pune
CreditAttribution: AjitS as a volunteer commented
Issue tags: -Needs reroll

Removing the tag as the rerolled patch is already in.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs work » Needs review
FileSize
3023183-12.patch19.88 KB

Reroll against the 8.x-1.x HEAD

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs review » Reviewed & tested by the community
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Reviewed & tested by the community » Patch (to be ported)

Thank you!

  • ilchovuchkov committed ca2ff30 on 8.x-1.x 
    Issue #3023183 by ilchovuchkov, idebr, lolandese, rpayanm, ajits: Code...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Patch (to be ported) » Fixed

Committed to the latest 8.x-1.x (dev) branch. Thank you again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.