Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Need proper Help overview page for the project. It difficult to anyone to understand the configuration of this module. Having the proper documentation of the configuration pages it will help to others.
https://www.drupal.org/node/632280
Proposed Solution
Provide the proper Help overview documentation for the project
Comment | File | Size | Author |
---|---|---|---|
#7 | with_patch_social_media_share.png | 100.43 KB | krina.addweb |
#7 | with_patch_social_media_share2.png | 21.64 KB | krina.addweb |
#7 | without_patch_social_media_share.png | 20.99 KB | krina.addweb |
#2 | help_overview-3054994-#1.patch | 1.26 KB | praveenneelu |
Comments
Comment #2
praveenneelu CreditAttribution: praveenneelu as a volunteer and commentedI applied a patch for Help overview page. Recommendations are welcome to update this issue. Kindly Review.
Comment #3
praveenneelu CreditAttribution: praveenneelu as a volunteer and commentedComment #4
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@Praveen Neelanathan, Thanks for the efforts. I checked your patch using simplytest.me and found that it does not apply as it shows The patch URL "https://www.drupal.org/files/issues/2019-05-16/help_overview-3054994-#1...." failed by HTTP status 404. error. Can you please share the correct patch. Thanks!
Comment #5
praveenneelu CreditAttribution: praveenneelu as a volunteer and commented@krina.addweb,
Thanks for your reply. The correct patch url is https://www.drupal.org/files/issues/2019-05-16/help_overview-3054994-%23...
Please check it.
Comment #6
praveenneelu CreditAttribution: praveenneelu as a volunteer and commentedComment #7
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@Praveen Neelanathan, Thanks for the patch. Your patch is working fine. I tested the patch in my local. PFA for the changes done.
Comment #8
praveenneelu CreditAttribution: praveenneelu as a volunteer and commented@krina.addweb
I saw the attachments, Thanks for your work.
Comment #9
scuba_flyThank you for your patch!
For the future please don't use # in the patch name. That makes it easier to apply and test the patch.
We could improve here to use a use statement for the RouteMatchInterface.
The } is not indented correctly
Also, hook help should return an empty string if the route does not match.
See help_page_test.module file.
Sorry for being strict about this.
I made a few changes before commit, see my commit below in a few minutes.
To be honest the string concatenation is not the nicest solution. But Drupal core also uses this, so let's commit this.
Comment #11
scuba_flyMy commit hook also detected some code style issues so I fixed that as well.