Problem/Motivation

We updated global heading styles as part of #3083231: Update heading font-sizes and line-heights and #3083004: Update heading spacings. This also led into some unpleasant changes in the status report designs.

Before

After

Proposed resolution

Override heading styles on the status report page so that the design remains the same as before these changes. These will be updated later once we implement a redesign of the page as a whole.

CommentFileSizeAuthor
#5 Screen Shot 2019-09-27 at 19.02.19.png362.93 KBlauriii
#5 interdiff.txt1.18 KBlauriii
#5 claro-status-report-regression-3084008-5.patch1.04 KBlauriii
#3 3084008-3.patch373 byteskostyashupenko
Screen Shot 2019-09-25 at 15.32.44.png221.19 KBlauriii
Screen Shot 2019-09-25 at 16.32.03.png192.7 KBlauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
FileSize
3084008-3.patch373 bytes

The actual font-size value was in em unit and margin with pixels

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Assigned: kostyashupenko » Unassigned
Status: Active » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue summary: View changes
FileSize
claro-status-report-regression-3084008-5.patch1.04 KB
interdiff.txt1.18 KB
Screen Shot 2019-09-27 at 19.02.19.png362.93 KB

Made some more fixes to the styles:

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented
Status: Needs review » Reviewed & tested by the community

Commit +1!

  • lauriii committed a2c8a41 on 8.x-1.x 
    Issue #3084008 by lauriii, kostyashupenko, huzooka: Fix regressions on...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thank you for the review! Committed 🚀

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.